The patch titled
Subject: brlocks-lglocks-cleanups-checkpatch-fixes
has been added to the -mm tree. Its filename is
brlocks-lglocks-cleanups-checkpatch-fixes.patch
Before you just go and hit "reply", please:
a) Consider who else should be cc'ed
b) Prefer to cc a suitable mailing list as well
c) Ideally: find the original patch on the mailing list and do a
reply-to-all to that, adding suitable additional cc's
*** Remember to use Documentation/SubmitChecklist when testing your code ***
The -mm tree is included into linux-next and is updated
there every 3-4 working days
------------------------------------------------------
From: Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx>
Subject: brlocks-lglocks-cleanups-checkpatch-fixes
ERROR: trailing whitespace
#788: FILE: include/linux/lglock.h:59:
+#endif $
WARNING: line over 80 characters
#792: FILE: include/linux/lglock.h:63:
+ DEFINE_PER_CPU(arch_spinlock_t, name ## _lock) = __ARCH_SPIN_LOCK_UNLOCKED; \
WARNING: line over 80 characters
#793: FILE: include/linux/lglock.h:64:
+ struct lglock name = { .lock = &name ## _lock, \
WARNING: please, no space before tabs
#793: FILE: include/linux/lglock.h:64:
+^Istruct lglock name = { .lock = &name ## _lock, ^I^I^I^I\$
WARNING: line over 80 characters
#794: FILE: include/linux/lglock.h:65:
+ .cpu_lock = __SPIN_LOCK_UNLOCKED(cpu_lock), \
WARNING: please, no space before tabs
#794: FILE: include/linux/lglock.h:65:
+^I^I^I .cpu_lock = __SPIN_LOCK_UNLOCKED(cpu_lock), ^I\$
WARNING: line over 80 characters
#808: FILE: include/linux/lglock.h:79:
+int lg_cpu_callback(struct notifier_block *nb, unsigned long action, void *hcpu);
ERROR: trailing whitespace
#970: FILE: kernel/lglock.c:7:
+/* Note there is no uninit, so lglocks cannot be defined in $
ERROR: trailing whitespace
#971: FILE: kernel/lglock.c:8:
+ * modules (but it's fine to use them from there) $
ERROR: trailing whitespace
#975: FILE: kernel/lglock.c:12:
+void lg_lock_init(struct lglock *lg, char *name) $
WARNING: space prohibited between function name and open parenthesis '('
#983: FILE: kernel/lglock.c:20:
+ for_each_online_cpu (i)
ERROR: trailing whitespace
#989: FILE: kernel/lglock.c:26:
+void lg_local_lock(struct lglock *lg) $
ERROR: trailing whitespace
#999: FILE: kernel/lglock.c:36:
+void lg_local_unlock(struct lglock *lg) $
ERROR: trailing whitespace
#1009: FILE: kernel/lglock.c:46:
+void lg_local_lock_cpu(struct lglock *lg, int cpu) $
ERROR: trailing whitespace
#1019: FILE: kernel/lglock.c:56:
+void lg_local_unlock_cpu(struct lglock *lg, int cpu) $
ERROR: trailing whitespace
#1029: FILE: kernel/lglock.c:66:
+void lg_global_lock_online(struct lglock *lg) $
ERROR: code indent should use tabs where possible
#1082: FILE: kernel/lglock.c:119:
+ unsigned long action, void *hcpu)$
WARNING: please, no spaces at the start of a line
#1082: FILE: kernel/lglock.c:119:
+ unsigned long action, void *hcpu)$
ERROR: trailing whitespace
#1083: FILE: kernel/lglock.c:120:
+{ $
ERROR: trailing whitespace
#1085: FILE: kernel/lglock.c:122:
+^Iswitch (action & ~CPU_TASKS_FROZEN) { $
ERROR: trailing whitespace
#1086: FILE: kernel/lglock.c:123:
+^Icase CPU_UP_PREPARE: $
ERROR: trailing whitespace
#1087: FILE: kernel/lglock.c:124:
+^I^Ispin_lock(&lglock->cpu_lock); $
ERROR: trailing whitespace
#1088: FILE: kernel/lglock.c:125:
+^I^Icpu_set((unsigned long)hcpu, lglock->cpus); $
ERROR: trailing whitespace
#1089: FILE: kernel/lglock.c:126:
+^I^Ispin_unlock(&lglock->cpu_lock); $
ERROR: trailing whitespace
#1090: FILE: kernel/lglock.c:127:
+^I^Ibreak; $
ERROR: trailing whitespace
#1091: FILE: kernel/lglock.c:128:
+^Icase CPU_UP_CANCELED: case CPU_DEAD: $
ERROR: trailing whitespace
#1092: FILE: kernel/lglock.c:129:
+^I^Ispin_lock(&lglock->cpu_lock); $
ERROR: trailing whitespace
#1093: FILE: kernel/lglock.c:130:
+^I^Icpu_clear((unsigned long)hcpu, lglock->cpus); $
ERROR: trailing whitespace
#1094: FILE: kernel/lglock.c:131:
+^I^Ispin_unlock(&lglock->cpu_lock); $
ERROR: trailing whitespace
#1095: FILE: kernel/lglock.c:132:
+^I} $
ERROR: trailing whitespace
#1096: FILE: kernel/lglock.c:133:
+^Ireturn NOTIFY_OK; $
total: 23 errors, 8 warnings, 974 lines checked
NOTE: whitespace errors detected, you may wish to use scripts/cleanpatch or
scripts/cleanfile
./patches/brlocks-lglocks-cleanups.patch has style problems, please review.
If any of these errors are false positives, please report
them to the maintainer, see CHECKPATCH in MAINTAINERS.
Please run checkpatch prior to sending patches
Cc: Al Viro <viro@xxxxxxxxxxxxxxxxxx>
Cc: Andi Kleen <ak@xxxxxxxxxxxxxxx>
Signed-off-by: Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx>
---
include/linux/lglock.h | 2 -
kernel/lglock.c | 42 +++++++++++++++++++--------------------
2 files changed, 22 insertions(+), 22 deletions(-)
diff -puN include/linux/lglock.h~brlocks-lglocks-cleanups-checkpatch-fixes include/linux/lglock.h
--- a/include/linux/lglock.h~brlocks-lglocks-cleanups-checkpatch-fixes
+++ a/include/linux/lglock.h
@@ -56,7 +56,7 @@ struct lglock {
#ifdef CONFIG_DEBUG_LOCK_ALLOC
struct lock_class_key lock_key;
struct lockdep_map lock_dep_map;
-#endif
+#endif
};
#define DEFINE_LGLOCK(name) \
diff -puN kernel/lglock.c~brlocks-lglocks-cleanups-checkpatch-fixes kernel/lglock.c
--- a/kernel/lglock.c~brlocks-lglocks-cleanups-checkpatch-fixes
+++ a/kernel/lglock.c
@@ -4,12 +4,12 @@
#include <linux/cpu.h>
#include <linux/string.h>
-/* Note there is no uninit, so lglocks cannot be defined in
- * modules (but it's fine to use them from there)
+/* Note there is no uninit, so lglocks cannot be defined in
+ * modules (but it's fine to use them from there)
* Could be added though, just undo lg_lock_init
*/
-void lg_lock_init(struct lglock *lg, char *name)
+void lg_lock_init(struct lglock *lg, char *name)
{
int i;
@@ -23,7 +23,7 @@ void lg_lock_init(struct lglock *lg, cha
}
EXPORT_SYMBOL(lg_lock_init);
-void lg_local_lock(struct lglock *lg)
+void lg_local_lock(struct lglock *lg)
{
arch_spinlock_t *lock;
preempt_disable();
@@ -33,7 +33,7 @@ void lg_local_lock(struct lglock *lg)
}
EXPORT_SYMBOL(lg_local_lock);
-void lg_local_unlock(struct lglock *lg)
+void lg_local_unlock(struct lglock *lg)
{
arch_spinlock_t *lock;
rwlock_release(&lg->lock_dep_map, 1, _RET_IP_);
@@ -43,7 +43,7 @@ void lg_local_unlock(struct lglock *lg)
}
EXPORT_SYMBOL(lg_local_unlock);
-void lg_local_lock_cpu(struct lglock *lg, int cpu)
+void lg_local_lock_cpu(struct lglock *lg, int cpu)
{
arch_spinlock_t *lock;
preempt_disable();
@@ -53,7 +53,7 @@ void lg_local_lock_cpu(struct lglock *lg
}
EXPORT_SYMBOL(lg_local_lock_cpu);
-void lg_local_unlock_cpu(struct lglock *lg, int cpu)
+void lg_local_unlock_cpu(struct lglock *lg, int cpu)
{
arch_spinlock_t *lock;
rwlock_release(&lg->lock_dep_map, 1, _RET_IP_);
@@ -63,7 +63,7 @@ void lg_local_unlock_cpu(struct lglock *
}
EXPORT_SYMBOL(lg_local_unlock_cpu);
-void lg_global_lock_online(struct lglock *lg)
+void lg_global_lock_online(struct lglock *lg)
{
int i;
spin_lock(&lg->cpu_lock);
@@ -117,20 +117,20 @@ EXPORT_SYMBOL(lg_global_unlock);
int lg_cpu_callback(struct notifier_block *nb,
unsigned long action, void *hcpu)
-{
+{
struct lglock *lglock = container_of(nb, struct lglock, cpu_notifier);
- switch (action & ~CPU_TASKS_FROZEN) {
- case CPU_UP_PREPARE:
- spin_lock(&lglock->cpu_lock);
- cpu_set((unsigned long)hcpu, lglock->cpus);
- spin_unlock(&lglock->cpu_lock);
- break;
- case CPU_UP_CANCELED: case CPU_DEAD:
- spin_lock(&lglock->cpu_lock);
- cpu_clear((unsigned long)hcpu, lglock->cpus);
- spin_unlock(&lglock->cpu_lock);
- }
- return NOTIFY_OK;
+ switch (action & ~CPU_TASKS_FROZEN) {
+ case CPU_UP_PREPARE:
+ spin_lock(&lglock->cpu_lock);
+ cpu_set((unsigned long)hcpu, lglock->cpus);
+ spin_unlock(&lglock->cpu_lock);
+ break;
+ case CPU_UP_CANCELED: case CPU_DEAD:
+ spin_lock(&lglock->cpu_lock);
+ cpu_clear((unsigned long)hcpu, lglock->cpus);
+ spin_unlock(&lglock->cpu_lock);
+ }
+ return NOTIFY_OK;
}
EXPORT_SYMBOL(lg_cpu_callback);
_
Subject: Subject: brlocks-lglocks-cleanups-checkpatch-fixes
Patches currently in -mm which might be from akpm@xxxxxxxxxxxxxxxxxxxx are
origin.patch
mm-fix-warnings-regarding-enum-migrate_mode.patch
linux-next.patch
i-need-old-gcc.patch
arch-alpha-kernel-systblss-remove-debug-check.patch
arch-x86-platform-iris-irisc-register-a-platform-device-and-a-platform-driver.patch
x86-olpc-xo15-sci-enable-lid-close-wakeup-control-through-sysfs.patch
drivers-platform-x86-sony-laptopc-fix-scancodes.patch
drivers-scsi-mpt2sas-mpt2sas_scsihc-spell-primitive-correctly.patch
drivers-scsi-megaraidc-fix-sparse-warnings-checkpatch-fixes.patch
drivers-usb-misc-emi26c-emi62c-fix-warnings.patch
mm.patch
mm-add-extra-free-kbytes-tunable-update-checkpatch-fixes.patch
hpet-factor-timer-allocate-from-open.patch
drivers-idle-intel_idlec-remove-redundant-local_irq_disable-call.patch
brlocks-lglocks-cleanups-checkpatch-fixes.patch
notify_change-check-that-i_mutex-is-held.patch
journal_add_journal_head-debug.patch
mutex-subsystem-synchro-test-module-fix.patch
slab-leaks3-default-y.patch
put_bh-debug.patch
--
To unsubscribe from this list: send the line "unsubscribe mm-commits" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
