The patch titled
Subject: mm: add missing mutex lock arround notify_change
has been added to the -mm tree. Its filename is
mm-add-missing-mutex-lock-arround-notify_change.patch
Before you just go and hit "reply", please:
a) Consider who else should be cc'ed
b) Prefer to cc a suitable mailing list as well
c) Ideally: find the original patch on the mailing list and do a
reply-to-all to that, adding suitable additional cc's
*** Remember to use Documentation/SubmitChecklist when testing your code ***
See http://userweb.kernel.org/~akpm/stuff/added-to-mm.txt to find
out what to do about this
The current -mm tree may be found at http://userweb.kernel.org/~akpm/mmotm/
------------------------------------------------------
From: Djalal Harouni <tixxdz@xxxxxxxxxx>
Subject: mm: add missing mutex lock arround notify_change
Calls to notify_change() must hold i_mutex.
Signed-off-by: Djalal Harouni <tixxdz@xxxxxxxxxx>
Cc: Hugh Dickins <hughd@xxxxxxxxxx>
Cc: Minchan Kim <minchan.kim@xxxxxxxxx>
Cc: KAMEZAWA Hiroyuki <kamezawa.hiroyu@xxxxxxxxxxxxxx>
Cc: Wu Fengguang <fengguang.wu@xxxxxxxxx>
Cc: Al Viro <viro@xxxxxxxxxxxxxxxxxx>
Cc: <stable@xxxxxxxxxxxxxxx>
Signed-off-by: Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx>
---
mm/filemap.c | 8 +++++++-
1 file changed, 7 insertions(+), 1 deletion(-)
diff -puN mm/filemap.c~mm-add-missing-mutex-lock-arround-notify_change mm/filemap.c
--- a/mm/filemap.c~mm-add-missing-mutex-lock-arround-notify_change
+++ a/mm/filemap.c
@@ -1994,10 +1994,16 @@ EXPORT_SYMBOL(should_remove_suid);
static int __remove_suid(struct dentry *dentry, int kill)
{
+ int ret;
struct iattr newattrs;
newattrs.ia_valid = ATTR_FORCE | kill;
- return notify_change(dentry, &newattrs);
+
+ mutex_lock(&dentry->d_inode->i_mutex);
+ ret = notify_change(dentry, &newattrs);
+ mutex_unlock(&dentry->d_inode->i_mutex);
+
+ return ret;
}
int file_remove_suid(struct file *file)
_
Subject: Subject: mm: add missing mutex lock arround notify_change
Patches currently in -mm which might be from tixxdz@xxxxxxxxxx are
origin.patch
linux-next.patch
mm-add-missing-mutex-lock-arround-notify_change.patch
notify_change-check-that-i_mutex-is-held.patch
--
To unsubscribe from this list: send the line "unsubscribe mm-commits" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
