The patch titled
Subject: ramoops: fix use of rounddown_pow_of_two()
has been added to the -mm tree. Its filename is
fixed-use-of-rounddown_pow_of_two-in-ramoops.patch
Before you just go and hit "reply", please:
a) Consider who else should be cc'ed
b) Prefer to cc a suitable mailing list as well
c) Ideally: find the original patch on the mailing list and do a
reply-to-all to that, adding suitable additional cc's
*** Remember to use Documentation/SubmitChecklist when testing your code ***
See http://userweb.kernel.org/~akpm/stuff/added-to-mm.txt to find
out what to do about this
The current -mm tree may be found at http://userweb.kernel.org/~akpm/mmotm/
------------------------------------------------------
From: Marco Stornelli <marco.stornelli@xxxxxxxxx>
Subject: ramoops: fix use of rounddown_pow_of_two()
The return value of rounddown_pow_of_two wasn't evaluated, so the
operation was a no-op.
Signed-off-by: Marco Stornelli <marco.stornelli@xxxxxxxxx>
Reported-by: Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx>
Reviewed-by: WANG Cong <xiyou.wangcong@xxxxxxxxx>
Signed-off-by: Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx>
---
drivers/char/ramoops.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff -puN drivers/char/ramoops.c~fixed-use-of-rounddown_pow_of_two-in-ramoops drivers/char/ramoops.c
--- a/drivers/char/ramoops.c~fixed-use-of-rounddown_pow_of_two-in-ramoops
+++ a/drivers/char/ramoops.c
@@ -126,8 +126,8 @@ static int __init ramoops_probe(struct p
goto fail3;
}
- rounddown_pow_of_two(pdata->mem_size);
- rounddown_pow_of_two(pdata->record_size);
+ pdata->mem_size = rounddown_pow_of_two(pdata->mem_size);
+ pdata->record_size = rounddown_pow_of_two(pdata->record_size);
/* Check for the minimum memory size */
if (pdata->mem_size < MIN_MEM_SIZE &&
_
Subject: Subject: ramoops: fix use of rounddown_pow_of_two()
Patches currently in -mm which might be from marco.stornelli@xxxxxxxxx are
fixed-use-of-rounddown_pow_of_two-in-ramoops.patch
ramoops-update-parameters-only-after-successful-init.patch
--
To unsubscribe from this list: send the line "unsubscribe mm-commits" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
