The patch titled
Subject: acpi: fix possible recursive locking in hwregs.c
has been added to the -mm tree. Its filename is
acpi-fix-possible-recursive-locking-in-hwregsc.patch
Before you just go and hit "reply", please:
a) Consider who else should be cc'ed
b) Prefer to cc a suitable mailing list as well
c) Ideally: find the original patch on the mailing list and do a
reply-to-all to that, adding suitable additional cc's
*** Remember to use Documentation/SubmitChecklist when testing your code ***
See http://userweb.kernel.org/~akpm/stuff/added-to-mm.txt to find
out what to do about this
The current -mm tree may be found at http://userweb.kernel.org/~akpm/mmotm/
------------------------------------------------------
From: Rakib Mullick <rakib.mullick@xxxxxxxxx>
Subject: acpi: fix possible recursive locking in hwregs.c
Calling pm-suspend triggers a recursive lock. In function
acpi_hw_clear_acpi_status(), acpi_os_release_lock() holds the lock
acpi_gbl_hardware_lock before calling acpi_hw_register_write(), then
without releasing acpi_gbl_hardware_lock, this function calls
acpi_ev_walk_gpe_list(), which also tries to hold acpi_gbl_hardware_lock and
thus causes a recursive lock.
Fix this by releasing acpi_gbl_hardware_lock before calling
acpi_ev_walk_gpe_list().
Signed-off-by: Rakib Mullick <rakib.mullick@xxxxxxxxx>
Cc: "Brown, Len" <len.brown@xxxxxxxxx>
Cc: Len Brown <lenb@xxxxxxxxxx>
Signed-off-by: Andrew Morton <akpm@xxxxxxxxxx>
---
drivers/acpi/acpica/hwregs.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff -puN drivers/acpi/acpica/hwregs.c~acpi-fix-possible-recursive-locking-in-hwregsc drivers/acpi/acpica/hwregs.c
--- a/drivers/acpi/acpica/hwregs.c~acpi-fix-possible-recursive-locking-in-hwregsc
+++ a/drivers/acpi/acpica/hwregs.c
@@ -269,6 +269,9 @@ acpi_status acpi_hw_clear_acpi_status(vo
status = acpi_hw_register_write(ACPI_REGISTER_PM1_STATUS,
ACPI_BITMASK_ALL_FIXED_STATUS);
+
+ acpi_os_release_lock(acpi_gbl_hardware_lock, lock_flags);
+
if (ACPI_FAILURE(status)) {
goto unlock_and_exit;
}
@@ -278,7 +281,6 @@ acpi_status acpi_hw_clear_acpi_status(vo
status = acpi_ev_walk_gpe_list(acpi_hw_clear_gpe_block, NULL);
unlock_and_exit:
- acpi_os_release_lock(acpi_gbl_hardware_lock, lock_flags);
return_ACPI_STATUS(status);
}
_
Subject: Subject: acpi: fix possible recursive locking in hwregs.c
Patches currently in -mm which might be from rakib.mullick@xxxxxxxxx are
acpi-fix-possible-recursive-locking-in-hwregsc.patch
--
To unsubscribe from this list: send the line "unsubscribe mm-commits" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
