[merged] netconsole-switch-init_netconsole-to-late_initcall.patch removed from -mm tree

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



The patch titled
     Subject: netconsole: switch init_netconsole() to late_initcall if build-in
has been removed from the -mm tree.  Its filename was
     netconsole-switch-init_netconsole-to-late_initcall.patch

This patch was dropped because it was merged into mainline or a subsystem tree

The current -mm tree may be found at http://userweb.kernel.org/~akpm/mmotm/

------------------------------------------------------
From: Lin Ming <ming.m.lin@xxxxxxxxx>
Subject: netconsole: switch init_netconsole() to late_initcall if build-in

Commit 88491d8 ("drivers/net: Kconfig & Makefile cleanup") causes a
regression that netconsole does not work if netconsole and network device
driver are build into kernel, because netconsole is linked before network
device driver.

Andrew Morton suggested to fix this with initcall ordering.  Fixes it by
switching init_netconsole() to late_initcall.

Signed-off-by: Lin Ming <ming.m.lin@xxxxxxxxx>
Cc: Jeff Kirsher <jeffrey.t.kirsher@xxxxxxxxx>
Cc: David Miller <davem@xxxxxxxxxxxxx>
Signed-off-by: Andrew Morton <akpm@xxxxxxxxxx>
---

 drivers/net/netconsole.c |    8 +++++++-
 1 file changed, 7 insertions(+), 1 deletion(-)

diff -puN drivers/net/netconsole.c~netconsole-switch-init_netconsole-to-late_initcall drivers/net/netconsole.c
--- a/drivers/net/netconsole.c~netconsole-switch-init_netconsole-to-late_initcall
+++ a/drivers/net/netconsole.c
@@ -799,5 +799,11 @@ static void __exit cleanup_netconsole(vo
 	}
 }
 
-module_init(init_netconsole);
+/*
+ * Use late_initcall to ensure netconsole is
+ * initialized after network device driver if built-in.
+ *
+ * late_initcall() and module_init() are identical if built as module.
+ */
+late_initcall(init_netconsole);
 module_exit(cleanup_netconsole);
_

Patches currently in -mm which might be from ming.m.lin@xxxxxxxxx are

origin.patch
linux-next.patch

--
To unsubscribe from this list: send the line "unsubscribe mm-commits" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Kernel Newbies FAQ]     [Kernel Archive]     [IETF Annouce]     [DCCP]     [Netdev]     [Networking]     [Security]     [Bugtraq]     [Photo]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]

  Powered by Linux