The patch titled arch/x86/mm/pageattr.c: quiet sparse noise; local functions should be static has been added to the -mm tree. Its filename is arch-x86-mm-pageattrc-quiet-sparse-noise-local-functions-should-be-static.patch Before you just go and hit "reply", please: a) Consider who else should be cc'ed b) Prefer to cc a suitable mailing list as well c) Ideally: find the original patch on the mailing list and do a reply-to-all to that, adding suitable additional cc's *** Remember to use Documentation/SubmitChecklist when testing your code *** See http://userweb.kernel.org/~akpm/stuff/added-to-mm.txt to find out what to do about this The current -mm tree may be found at http://userweb.kernel.org/~akpm/mmotm/ ------------------------------------------------------ Subject: arch/x86/mm/pageattr.c: quiet sparse noise; local functions should be static From: H Hartley Sweeten <hartleys@xxxxxxxxxxxxxxxxxxx> Local functions should be marked static. Â This quiets the following sparse noise: warning: symbol '_set_memory_array' was not declared. Should it be static? Signed-off-by: H Hartley Sweeten <hsweeten@xxxxxxxxxxxxxxxxxxx> Signed-off-by: Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx> --- arch/x86/mm/pageattr.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff -puN arch/x86/mm/pageattr.c~arch-x86-mm-pageattrc-quiet-sparse-noise-local-functions-should-be-static arch/x86/mm/pageattr.c --- a/arch/x86/mm/pageattr.c~arch-x86-mm-pageattrc-quiet-sparse-noise-local-functions-should-be-static +++ a/arch/x86/mm/pageattr.c @@ -998,7 +998,7 @@ out_err: } EXPORT_SYMBOL(set_memory_uc); -int _set_memory_array(unsigned long *addr, int addrinarray, +static int _set_memory_array(unsigned long *addr, int addrinarray, unsigned long new_type) { int i, j; _ Patches currently in -mm which might be from hartleys@xxxxxxxxxxxxxxxxxxx are arch-x86-kernel-e820c-quiet-sparse-noise-about-plain-integer-as-null-pointer.patch arch-x86-kernel-ptracec-quiet-sparse-noise.patch arch-x86-mm-pageattrc-quiet-sparse-noise-local-functions-should-be-static.patch lib-bitmapc-quiet-sparse-noise-about-address-space.patch lib-bitmapc-quiet-sparse-noise-about-address-space-fix.patch vt-suspend-cleanup-if-defined-uglyness-and-fix-compile-error.patch -- To unsubscribe from this list: send the line "unsubscribe mm-commits" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html