The patch titled
um: drivers/xterm.c: fix a file descriptor leak
has been added to the -mm tree. Its filename is
um-drivers-xtermc-fix-a-file-descriptor-leak.patch
Before you just go and hit "reply", please:
a) Consider who else should be cc'ed
b) Prefer to cc a suitable mailing list as well
c) Ideally: find the original patch on the mailing list and do a
reply-to-all to that, adding suitable additional cc's
*** Remember to use Documentation/SubmitChecklist when testing your code ***
See http://userweb.kernel.org/~akpm/stuff/added-to-mm.txt to find
out what to do about this
The current -mm tree may be found at http://userweb.kernel.org/~akpm/mmotm/
------------------------------------------------------
Subject: um: drivers/xterm.c: fix a file descriptor leak
From: Jonathan Neuschäfer <j.neuschaefer@xxxxxxx>
I could use out_close1, but that seems to be the code path to close the fd
returned by os_create_unix_socket, and using it to close the fd returned
by mkstemp might lead to some confusion, so I don't do it.
Signed-off-by: Jonathan Neuschäfer <j.neuschaefer@xxxxxxx>
Signed-off-by: Richard Weinberger <richard@xxxxxx>
Signed-off-by: Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx>
---
arch/um/drivers/xterm.c | 1 +
1 file changed, 1 insertion(+)
diff -puN arch/um/drivers/xterm.c~um-drivers-xtermc-fix-a-file-descriptor-leak arch/um/drivers/xterm.c
--- a/arch/um/drivers/xterm.c~um-drivers-xtermc-fix-a-file-descriptor-leak
+++ a/arch/um/drivers/xterm.c
@@ -123,6 +123,7 @@ static int xterm_open(int input, int out
err = -errno;
printk(UM_KERN_ERR "xterm_open : unlink failed, errno = %d\n",
errno);
+ close(fd);
return err;
}
close(fd);
_
Patches currently in -mm which might be from j.neuschaefer@xxxxxxx are
um-drivers-xtermc-fix-a-file-descriptor-leak.patch
--
To unsubscribe from this list: send the line "unsubscribe mm-commits" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
