The patch titled drivers/misc/fsa9480.c: fix a leak of the IRQ during init failure has been added to the -mm tree. Its filename is drivers-misc-fsa9480-fix-a-leak-of-the-irq-during-init-failure.patch Before you just go and hit "reply", please: a) Consider who else should be cc'ed b) Prefer to cc a suitable mailing list as well c) Ideally: find the original patch on the mailing list and do a reply-to-all to that, adding suitable additional cc's *** Remember to use Documentation/SubmitChecklist when testing your code *** See http://userweb.kernel.org/~akpm/stuff/added-to-mm.txt to find out what to do about this The current -mm tree may be found at http://userweb.kernel.org/~akpm/mmotm/ ------------------------------------------------------ Subject: drivers/misc/fsa9480.c: fix a leak of the IRQ during init failure From: Axel Lin <axel.lin@xxxxxxxxx> Make sure we are passing the same cookie in all calls to request_threaded_irq() and free_irq(). Signed-off-by: Axel Lin <axel.lin@xxxxxxxxx> Cc: Donggeun Kim <dg77.kim@xxxxxxxxxxx> Cc: Minkyu Kang <mk7.kang@xxxxxxxxxxx> Cc: Kyungmin Park <kyungmin.park@xxxxxxxxxxx> Signed-off-by: Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx> --- drivers/misc/fsa9480.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff -puN drivers/misc/fsa9480.c~drivers-misc-fsa9480-fix-a-leak-of-the-irq-during-init-failure drivers/misc/fsa9480.c --- a/drivers/misc/fsa9480.c~drivers-misc-fsa9480-fix-a-leak-of-the-irq-during-init-failure +++ a/drivers/misc/fsa9480.c @@ -455,7 +455,7 @@ static int __devinit fsa9480_probe(struc fail2: if (client->irq) - free_irq(client->irq, NULL); + free_irq(client->irq, usbsw); fail1: i2c_set_clientdata(client, NULL); kfree(usbsw); @@ -466,7 +466,7 @@ static int __devexit fsa9480_remove(stru { struct fsa9480_usbsw *usbsw = i2c_get_clientdata(client); if (client->irq) - free_irq(client->irq, NULL); + free_irq(client->irq, usbsw); i2c_set_clientdata(client, NULL); sysfs_remove_group(&client->dev.kobj, &fsa9480_group); _ Patches currently in -mm which might be from axel.lin@xxxxxxxxx are origin.patch drivers-video-backlight-ep93xx_blc-add-missing-include-of-linux-moduleh.patch leds-add-missing-include-of-linux-moduleh.patch backlight-fix-module-alias-prefix-for-adp8870_bl.patch drivers-misc-fsa9480-fix-a-leak-of-the-irq-during-init-failure.patch linux-next.patch leds-renesas-tpu-led-driver-v2-fix.patch -- To unsubscribe from this list: send the line "unsubscribe mm-commits" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html