The patch titled
oprofilefs: handle zero-length writes
has been added to the -mm tree. Its filename is
oprofilefs-handle-zero-length-writes.patch
Before you just go and hit "reply", please:
a) Consider who else should be cc'ed
b) Prefer to cc a suitable mailing list as well
c) Ideally: find the original patch on the mailing list and do a
reply-to-all to that, adding suitable additional cc's
*** Remember to use Documentation/SubmitChecklist when testing your code ***
See http://userweb.kernel.org/~akpm/stuff/added-to-mm.txt to find
out what to do about this
The current -mm tree may be found at http://userweb.kernel.org/~akpm/mmotm/
------------------------------------------------------
Subject: oprofilefs: handle zero-length writes
From: Mike Waychison <mikew@xxxxxxxxxx>
Currently in oprofilefs, files that use ulong_fops mis-handle writes of
zero length. A count of 0 causes oprofilefs_ulong_from_user to return 0
(success), which then leads to oprofile_set_ulong being called to stuff
"value" into file->private_data without it being initialized.
Fix this by moving the check for a zero-length write up into
ulong_write_file.
Signed-off-by: Mike Waychison <mikew@xxxxxxxxxx>
Cc: Robert Richter <robert.richter@xxxxxxx>
Signed-off-by: Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx>
---
drivers/oprofile/oprofilefs.c | 5 ++---
1 file changed, 2 insertions(+), 3 deletions(-)
diff -puN drivers/oprofile/oprofilefs.c~oprofilefs-handle-zero-length-writes drivers/oprofile/oprofilefs.c
--- a/drivers/oprofile/oprofilefs.c~oprofilefs-handle-zero-length-writes
+++ a/drivers/oprofile/oprofilefs.c
@@ -65,9 +65,6 @@ int oprofilefs_ulong_from_user(unsigned
char tmpbuf[TMPBUFSIZE];
unsigned long flags;
- if (!count)
- return 0;
-
if (count > TMPBUFSIZE - 1)
return -EINVAL;
@@ -97,6 +94,8 @@ static ssize_t ulong_write_file(struct f
if (*offset)
return -EINVAL;
+ if (count == 0)
+ return 0;
retval = oprofilefs_ulong_from_user(&value, buf, count);
if (retval)
_
Patches currently in -mm which might be from mikew@xxxxxxxxxx are
linux-next.patch
oprofilefs-handle-zero-length-writes.patch
--
To unsubscribe from this list: send the line "unsubscribe mm-commits" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
