The patch titled do_coredump: fix the "ispipe" error check has been removed from the -mm tree. Its filename was do_coredump-fix-the-ispipe-error-check.patch This patch was dropped because it was merged into mainline or a subsystem tree The current -mm tree may be found at http://userweb.kernel.org/~akpm/mmotm/ ------------------------------------------------------ Subject: do_coredump: fix the "ispipe" error check From: Oleg Nesterov <oleg@xxxxxxxxxx> do_coredump() assumes that if format_corename() fails it should return -ENOMEM. This is not true, for example cn_print_exe_file() can propagate the error from d_path. Even if it was true, this is too fragile. Change the code to check "ispipe < 0". Signed-off-by: Oleg Nesterov <oleg@xxxxxxxxxx> Signed-off-by: Jiri Slaby <jslaby@xxxxxxx> Reviewed-by: Neil Horman <nhorman@xxxxxxxxxxxxx> Signed-off-by: Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx> --- fs/exec.c | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) diff -puN fs/exec.c~do_coredump-fix-the-ispipe-error-check fs/exec.c --- a/fs/exec.c~do_coredump-fix-the-ispipe-error-check +++ a/fs/exec.c @@ -2133,16 +2133,16 @@ void do_coredump(long signr, int exit_co ispipe = format_corename(&cn, signr); - if (ispipe == -ENOMEM) { - printk(KERN_WARNING "format_corename failed\n"); - printk(KERN_WARNING "Aborting core\n"); - goto fail_corename; - } - if (ispipe) { int dump_count; char **helper_argv; + if (ispipe < 0) { + printk(KERN_WARNING "format_corename failed\n"); + printk(KERN_WARNING "Aborting core\n"); + goto fail_corename; + } + if (cprm.limit == 1) { /* * Normally core limits are irrelevant to pipes, since _ Patches currently in -mm which might be from oleg@xxxxxxxxxx are origin.patch signals-sys_ssetmask-sys_rt_sigsuspend-should-use-set_current_blocked.patch linux-next.patch proc_fork_connector-a-lockless-real_parent-usage-is-not-safe.patch ipc-introduce-shm_rmid_forced-sysctl-testing.patch -- To unsubscribe from this list: send the line "unsubscribe mm-commits" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html