+ uml-drivers-net_userc-memory-leak-fix.patch added to -mm tree

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



The patch titled
     uml: drivers/net_user.c memory leak fix
has been added to the -mm tree.  Its filename is
     uml-drivers-net_userc-memory-leak-fix.patch

Before you just go and hit "reply", please:
   a) Consider who else should be cc'ed
   b) Prefer to cc a suitable mailing list as well
   c) Ideally: find the original patch on the mailing list and do a
      reply-to-all to that, adding suitable additional cc's

*** Remember to use Documentation/SubmitChecklist when testing your code ***

See http://userweb.kernel.org/~akpm/stuff/added-to-mm.txt to find
out what to do about this

The current -mm tree may be found at http://userweb.kernel.org/~akpm/mmotm/

------------------------------------------------------
Subject: uml: drivers/net_user.c memory leak fix
From: Vitaliy Ivanov <vitalivanov@xxxxxxxxx>

Perform memory cleanup on exit.  On receiving invalid 'pid' we still
should clean 'output' variable.

Signed-off-by: Vitaliy Ivanov <vitalivanov@xxxxxxxxx>
Signed-off-by: Richard Weinberger <richard@xxxxxx>
Signed-off-by: Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx>
---

 arch/um/drivers/net_user.c |    5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)

diff -puN arch/um/drivers/net_user.c~uml-drivers-net_userc-memory-leak-fix arch/um/drivers/net_user.c
--- a/arch/um/drivers/net_user.c~uml-drivers-net_userc-memory-leak-fix
+++ a/arch/um/drivers/net_user.c
@@ -228,7 +228,10 @@ static void change(char *dev, char *what
 		       "buffer\n");
 
 	pid = change_tramp(argv, output, output_len);
-	if (pid < 0) return;
+	if (pid < 0) {
+		kfree(output);
+		return;
+	}
 
 	if (output != NULL) {
 		printk("%s", output);
_

Patches currently in -mm which might be from vitalivanov@xxxxxxxxx are

linux-next.patch
um-fix-_fortify_source=2-support-for-kernel-modules.patch
uml-drivers-net_userc-memory-leak-fix.patch
gcov-disable-constructors-for-uml.patch

--
To unsubscribe from this list: send the line "unsubscribe mm-commits" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Kernel Newbies FAQ]     [Kernel Archive]     [IETF Annouce]     [DCCP]     [Netdev]     [Networking]     [Security]     [Bugtraq]     [Photo]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]

  Powered by Linux