+ drivers-tty-serial-pch_uartc-dont-oops-if-dmi_get_system_info-returns-null.patch added to -mm tree

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



The patch titled
     drivers/tty/serial/pch_uart.c: don't oops if dmi_get_system_info returns NULL
has been added to the -mm tree.  Its filename is
     drivers-tty-serial-pch_uartc-dont-oops-if-dmi_get_system_info-returns-null.patch

Before you just go and hit "reply", please:
   a) Consider who else should be cc'ed
   b) Prefer to cc a suitable mailing list as well
   c) Ideally: find the original patch on the mailing list and do a
      reply-to-all to that, adding suitable additional cc's

*** Remember to use Documentation/SubmitChecklist when testing your code ***

See http://userweb.kernel.org/~akpm/stuff/added-to-mm.txt to find
out what to do about this

The current -mm tree may be found at http://userweb.kernel.org/~akpm/mmotm/

------------------------------------------------------
Subject: drivers/tty/serial/pch_uart.c: don't oops if dmi_get_system_info returns NULL
From: Alexander Stein <alexander.stein@xxxxxxxxxxxxxxxxxxxxx>

If dmi_get_system_info() returns NULL, pch_uart_init_port() will
dereferencea zero pointer.

Signed-off-by: Alexander Stein <alexander.stein@xxxxxxxxxxxxxxxxxxxxx>
Cc: Greg KH <gregkh@xxxxxxx>
Cc: <stable@xxxxxxxxxx>
Signed-off-by: Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx>
---

 drivers/tty/serial/pch_uart.c |    4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff -puN drivers/tty/serial/pch_uart.c~drivers-tty-serial-pch_uartc-dont-oops-if-dmi_get_system_info-returns-null drivers/tty/serial/pch_uart.c
--- a/drivers/tty/serial/pch_uart.c~drivers-tty-serial-pch_uartc-dont-oops-if-dmi_get_system_info-returns-null
+++ a/drivers/tty/serial/pch_uart.c
@@ -1396,6 +1396,7 @@ static struct eg20t_port *pch_uart_init_
 	int fifosize, base_baud;
 	int port_type;
 	struct pch_uart_driver_data *board;
+	const char *board_name;
 
 	board = &drv_dat[id->driver_data];
 	port_type = board->port_type;
@@ -1411,7 +1412,8 @@ static struct eg20t_port *pch_uart_init_
 	base_baud = 1843200; /* 1.8432MHz */
 
 	/* quirk for CM-iTC board */
-	if (strstr(dmi_get_system_info(DMI_BOARD_NAME), "CM-iTC"))
+	board_name = dmi_get_system_info(DMI_BOARD_NAME);
+	if (board_name && strstr(board_name, "CM-iTC"))
 		base_baud = 192000000; /* 192.0MHz */
 
 	switch (port_type) {
_

Patches currently in -mm which might be from alexander.stein@xxxxxxxxxxxxxxxxxxxxx are

drivers-tty-serial-pch_uartc-dont-oops-if-dmi_get_system_info-returns-null.patch

--
To unsubscribe from this list: send the line "unsubscribe mm-commits" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Kernel Newbies FAQ]     [Kernel Archive]     [IETF Annouce]     [DCCP]     [Netdev]     [Networking]     [Security]     [Bugtraq]     [Photo]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]

  Powered by Linux