The patch titled pagewalk: fix walk_page_range() don't check find_vma() result properly has been added to the -mm tree. Its filename is pagewalk-fix-walk_page_range-dont-check-find_vma-result-properly.patch Before you just go and hit "reply", please: a) Consider who else should be cc'ed b) Prefer to cc a suitable mailing list as well c) Ideally: find the original patch on the mailing list and do a reply-to-all to that, adding suitable additional cc's *** Remember to use Documentation/SubmitChecklist when testing your code *** See http://userweb.kernel.org/~akpm/stuff/added-to-mm.txt to find out what to do about this The current -mm tree may be found at http://userweb.kernel.org/~akpm/mmotm/ ------------------------------------------------------ Subject: pagewalk: fix walk_page_range() don't check find_vma() result properly From: KOSAKI Motohiro <kosaki.motohiro@xxxxxxxxxxxxxx> The doc of find_vma() says, /* Look up the first VMA which satisfies addr < vm_end, NULL if none. */ struct vm_area_struct *find_vma(struct mm_struct *mm, unsigned long addr) { (snip) Thus, caller should confirm whether the returned vma matches a desired one. Signed-off-by: KOSAKI Motohiro <kosaki.motohiro@xxxxxxxxxxxxxx> Cc: Naoya Horiguchi <n-horiguchi@xxxxxxxxxxxxx> Cc: Hiroyuki Kamezawa <kamezawa.hiroyuki@xxxxxxxxx> Cc: Andrea Arcangeli <aarcange@xxxxxxxxxx> Cc: Matt Mackall <mpm@xxxxxxxxxxx> Signed-off-by: Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx> --- mm/pagewalk.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff -puN mm/pagewalk.c~pagewalk-fix-walk_page_range-dont-check-find_vma-result-properly mm/pagewalk.c --- a/mm/pagewalk.c~pagewalk-fix-walk_page_range-dont-check-find_vma-result-properly +++ a/mm/pagewalk.c @@ -176,7 +176,7 @@ int walk_page_range(unsigned long addr, * we can't handled it in the same manner as non-huge pages. */ vma = find_vma(walk->mm, addr); - if (vma && is_vm_hugetlb_page(vma)) { + if (vma && vma->vm_start <= addr && is_vm_hugetlb_page(vma)) { if (vma->vm_end < next) next = vma->vm_end; /* _ Patches currently in -mm which might be from kosaki.motohiro@xxxxxxxxxxxxxx are vmscanmemcg-memcg-aware-swap-token.patch vmscanmemcg-memcg-aware-swap-token-fix.patch vmscanmemcg-memcg-aware-swap-token-fix-checkpatch-fixes.patch vmscan-implement-swap-token-trace.patch vmscan-implement-swap-token-priority-aging.patch memcg-add-documentation-for-the-memorynumastat-api.patch memcg-add-documentation-for-the-memorynumastat-api-fix.patch mm-increase-reclaim_distance-to-30.patch slab-use-numa_no_node.patch mm-swap-token-fix-dead-link.patch mm-swap-token-makes-global-variables-to-function-local.patch mm-swap-token-add-a-comment-for-priority-aging.patch pagewalk-fix-walk_page_range-dont-check-find_vma-result-properly.patch pagewalk-dont-look-up-vma-if-walk-hugetlb_entry-is-unused.patch pagewalk-add-locking-rule-comments.patch pagewalk-add-locking-rule-comments-fix.patch pagewalk-fix-code-comment-for-thp.patch cpusets-randomize-node-rotor-used-in-cpuset_mem_spread_node.patch cpusets-randomize-node-rotor-used-in-cpuset_mem_spread_node-fix-2.patch cpusets-randomize-node-rotor-used-in-cpuset_mem_spread_node-cpusets-initialize-spread-rotor-lazily.patch cpumask-convert-for_each_cpumask-with-for_each_cpu.patch cpumask-alloc_cpumask_var-use-numa_no_node.patch cpumask-add-cpumask_var_t-documentation.patch kexec-remove-kmsg_dump_kexec.patch kexec-remove-kmsg_dump_kexec-fix.patch -- To unsubscribe from this list: send the line "unsubscribe mm-commits" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html