[nacked] coredump-use-get_task_comm-for-%e-filename-format.patch removed from -mm tree

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



The patch titled
     coredump: use get_task_comm() for %e filename format
has been removed from the -mm tree.  Its filename was
     coredump-use-get_task_comm-for-%e-filename-format.patch

This patch was dropped because it was nacked

The current -mm tree may be found at http://userweb.kernel.org/~akpm/mmotm/

------------------------------------------------------
Subject: coredump: use get_task_comm() for %e filename format
From: Jiri Slaby <jslaby@xxxxxxx>

We currently access current->comm directly.  As we have
prctl(PR_SET_NAME), we need the access be protected by task_lock.  This is
exactly what get_task_comm does, so use it.

I'm not 100% convinced prctl(PR_SET_NAME) may be called at the time of
core dump, but the locking won't hurt.  Note that siglock is not held in
format_corename.

Signed-off-by: Jiri Slaby <jslaby@xxxxxxx>
Cc: Alan Cox <alan@xxxxxxxxxxxxxxxxxxx>
Cc: Andi Kleen <andi@xxxxxxxxxxxxxx>
Cc: John Stultz <john.stultz@xxxxxxxxxx>
Signed-off-by: Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx>
---

 fs/exec.c |    7 +++++--
 1 file changed, 5 insertions(+), 2 deletions(-)

diff -puN fs/exec.c~coredump-use-get_task_comm-for-%e-filename-format fs/exec.c
--- a/fs/exec.c~coredump-use-get_task_comm-for-%e-filename-format
+++ a/fs/exec.c
@@ -1726,9 +1726,12 @@ static int format_corename(struct core_n
 				up_read(&uts_sem);
 				break;
 			/* executable */
-			case 'e':
-				err = cn_printf(cn, "%s", current->comm);
+			case 'e': {
+				char comm[TASK_COMM_LEN];
+				err = cn_printf(cn, "%s",
+						get_task_comm(comm, current));
 				break;
+			}
 			case 'E':
 				err = cn_print_exe_file(cn);
 				break;
_

Patches currently in -mm which might be from jslaby@xxxxxxx are

origin.patch
coredump-use-task-comm-instead-of-unknown.patch
coredump-escape-in-hostname-and-comm.patch
leds-route-kbd-leds-through-the-generic-leds-layer.patch

--
To unsubscribe from this list: send the line "unsubscribe mm-commits" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Kernel Newbies FAQ]     [Kernel Archive]     [IETF Annouce]     [DCCP]     [Netdev]     [Networking]     [Security]     [Bugtraq]     [Photo]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]

  Powered by Linux