The patch titled mm: check if any page in a pageblock is reserved before marking it MIGRATE_RESERVE has been removed from the -mm tree. Its filename was mm-check-if-any-page-in-a-pageblock-is-reserved-before-marking-it-migrate_reserve.patch This patch was dropped because it was merged into mainline or a subsystem tree The current -mm tree may be found at http://userweb.kernel.org/~akpm/mmotm/ ------------------------------------------------------ Subject: mm: check if any page in a pageblock is reserved before marking it MIGRATE_RESERVE From: Arve Hjønnevåg <arve@xxxxxxxxxxx> This fixes a problem where the first pageblock got marked MIGRATE_RESERVE even though it only had a few free pages. eg, On current ARM port, The kernel starts at offset 0x8000 to leave room for boot parameters, and the memory is freed later. This in turn caused no contiguous memory to be reserved and frequent kswapd wakeups that emptied the caches to get more contiguous memory. Unfortunatelly, ARM needs order-2 allocation for pgd (see arm/mm/pgd.c#pgd_alloc()). Therefore the issue is not minor nor easy avoidable. [kosaki.motohiro@xxxxxxxxxxxxxx: added some explanation] [kosaki.motohiro@xxxxxxxxxxxxxx: add !pfn_valid_within() to check] [minchan.kim@xxxxxxxxx: check end_pfn in pageblock_is_reserved] Signed-off-by: John Stultz <john.stultz@xxxxxxxxxx> Signed-off-by: Arve Hjønnevåg <arve@xxxxxxxxxxx> Signed-off-by: KOSAKI Motohiro <kosaki.motohiro@xxxxxxxxxxxxxx> Acked-by: Mel Gorman <mel@xxxxxxxxx> Acked-by: Dave Hansen <dave@xxxxxxxxxxxxxxxxxx> Signed-off-by: Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx> --- mm/page_alloc.c | 19 +++++++++++++++++-- 1 file changed, 17 insertions(+), 2 deletions(-) diff -puN mm/page_alloc.c~mm-check-if-any-page-in-a-pageblock-is-reserved-before-marking-it-migrate_reserve mm/page_alloc.c --- a/mm/page_alloc.c~mm-check-if-any-page-in-a-pageblock-is-reserved-before-marking-it-migrate_reserve +++ a/mm/page_alloc.c @@ -3329,6 +3329,20 @@ static inline unsigned long wait_table_b #define LONG_ALIGN(x) (((x)+(sizeof(long))-1)&~((sizeof(long))-1)) /* + * Check if a pageblock contains reserved pages + */ +static int pageblock_is_reserved(unsigned long start_pfn, unsigned long end_pfn) +{ + unsigned long pfn; + + for (pfn = start_pfn; pfn < end_pfn; pfn++) { + if (!pfn_valid_within(pfn) || PageReserved(pfn_to_page(pfn))) + return 1; + } + return 0; +} + +/* * Mark a number of pageblocks as MIGRATE_RESERVE. The number * of blocks reserved is based on min_wmark_pages(zone). The memory within * the reserve will tend to store contiguous free pages. Setting min_free_kbytes @@ -3337,7 +3351,7 @@ static inline unsigned long wait_table_b */ static void setup_zone_migrate_reserve(struct zone *zone) { - unsigned long start_pfn, pfn, end_pfn; + unsigned long start_pfn, pfn, end_pfn, block_end_pfn; struct page *page; unsigned long block_migratetype; int reserve; @@ -3367,7 +3381,8 @@ static void setup_zone_migrate_reserve(s continue; /* Blocks with reserved pages will never free, skip them. */ - if (PageReserved(page)) + block_end_pfn = min(pfn + pageblock_nr_pages, end_pfn); + if (pageblock_is_reserved(pfn, block_end_pfn)) continue; block_migratetype = get_pageblock_migratetype(page); _ Patches currently in -mm which might be from arve@xxxxxxxxxxx are origin.patch -- To unsubscribe from this list: send the line "unsubscribe mm-commits" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html