The patch titled
task->comm: ext4: protect task->comm access by using get_task_comm()
has been removed from the -mm tree. Its filename was
task-comm-ext4-protect-task-comm-access-by-using-get_task_comm.patch
This patch was dropped because an updated version will be merged
The current -mm tree may be found at http://userweb.kernel.org/~akpm/mmotm/
------------------------------------------------------
Subject: task->comm: ext4: protect task->comm access by using get_task_comm()
From: John Stultz <john.stultz@xxxxxxxxxx>
Convert ext4 comm access to use the safe get_task_comm() accessor.
Signed-off-by: John Stultz <john.stultz@xxxxxxxxxx>
Cc: KOSAKI Motohiro <kosaki.motohiro@xxxxxxxxxxxxxx>
Cc: David Rientjes <rientjes@xxxxxxxxxx>
Cc: Dave Hansen <dave@xxxxxxxxxxxxxxxxxx>
Cc: Thomas Gleixner <tglx@xxxxxxxxxxxxx>
Cc: Theodore Ts'o <tytso@xxxxxxx>
Signed-off-by: Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx>
---
fs/ext4/file.c | 8 ++++++--
fs/ext4/super.c | 13 ++++++++++---
2 files changed, 16 insertions(+), 5 deletions(-)
diff -puN fs/ext4/file.c~task-comm-ext4-protect-task-comm-access-by-using-get_task_comm fs/ext4/file.c
--- a/fs/ext4/file.c~task-comm-ext4-protect-task-comm-access-by-using-get_task_comm
+++ a/fs/ext4/file.c
@@ -124,11 +124,15 @@ ext4_file_write(struct kiocb *iocb, cons
static unsigned long unaligned_warn_time;
/* Warn about this once per day */
- if (printk_timed_ratelimit(&unaligned_warn_time, 60*60*24*HZ))
+ if (printk_timed_ratelimit(&unaligned_warn_time, 60*60*24*HZ)) {
+ char comm[TASK_COMM_LEN];
+
+ get_task_comm(comm, current);
ext4_msg(inode->i_sb, KERN_WARNING,
"Unaligned AIO/DIO on inode %ld by %s; "
"performance will be poor.",
- inode->i_ino, current->comm);
+ inode->i_ino, comm);
+ }
mutex_lock(ext4_aio_mutex(inode));
ext4_aiodio_wait(inode);
}
diff -puN fs/ext4/super.c~task-comm-ext4-protect-task-comm-access-by-using-get_task_comm fs/ext4/super.c
--- a/fs/ext4/super.c~task-comm-ext4-protect-task-comm-access-by-using-get_task_comm
+++ a/fs/ext4/super.c
@@ -426,12 +426,15 @@ void __ext4_error(struct super_block *sb
{
struct va_format vaf;
va_list args;
+ char comm[TASK_COMM_LEN];
va_start(args, fmt);
vaf.fmt = fmt;
vaf.va = &args;
+
+ get_task_comm(comm, current);
printk(KERN_CRIT "EXT4-fs error (device %s): %s:%d: comm %s: %pV\n",
- sb->s_id, function, line, current->comm, &vaf);
+ sb->s_id, function, line, comm, &vaf);
va_end(args);
ext4_handle_error(sb);
@@ -444,6 +447,7 @@ void ext4_error_inode(struct inode *inod
va_list args;
struct va_format vaf;
struct ext4_super_block *es = EXT4_SB(inode->i_sb)->s_es;
+ char comm[TASK_COMM_LEN];
es->s_last_error_ino = cpu_to_le32(inode->i_ino);
es->s_last_error_block = cpu_to_le64(block);
@@ -455,7 +459,8 @@ void ext4_error_inode(struct inode *inod
inode->i_sb->s_id, function, line, inode->i_ino);
if (block)
printk(KERN_CONT "block %llu: ", block);
- printk(KERN_CONT "comm %s: %pV\n", current->comm, &vaf);
+ get_task_comm(comm, current);
+ printk(KERN_CONT "comm %s: %pV\n", comm, &vaf);
va_end(args);
ext4_handle_error(inode->i_sb);
@@ -470,6 +475,7 @@ void ext4_error_file(struct file *file,
struct ext4_super_block *es;
struct inode *inode = file->f_dentry->d_inode;
char pathname[80], *path;
+ char comm[TASK_COMM_LEN];
es = EXT4_SB(inode->i_sb)->s_es;
es->s_last_error_ino = cpu_to_le32(inode->i_ino);
@@ -485,7 +491,8 @@ void ext4_error_file(struct file *file,
va_start(args, fmt);
vaf.fmt = fmt;
vaf.va = &args;
- printk(KERN_CONT "comm %s: path %s: %pV\n", current->comm, path, &vaf);
+ get_task_comm(comm, current);
+ printk(KERN_CONT "comm %s: path %s: %pV\n", comm, path, &vaf);
va_end(args);
ext4_handle_error(inode->i_sb);
_
Patches currently in -mm which might be from john.stultz@xxxxxxxxxx are
mm-check-if-any-page-in-a-pageblock-is-reserved-before-marking-it-migrate_reserve.patch
mm-check-if-any-page-in-a-pageblock-is-reserved-before-marking-it-migrate_reserve-fix.patch
drivers-rtc-rtc-pcf50633c-dont-request-update-irq.patch
--
To unsubscribe from this list: send the line "unsubscribe mm-commits" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
