The patch titled Documentation/atomic_ops.txt: avoid volatile in sample code has been added to the -mm tree. Its filename is documentation-atomic_opstxt-avoid-volatile-in-sample-code.patch Before you just go and hit "reply", please: a) Consider who else should be cc'ed b) Prefer to cc a suitable mailing list as well c) Ideally: find the original patch on the mailing list and do a reply-to-all to that, adding suitable additional cc's *** Remember to use Documentation/SubmitChecklist when testing your code *** See http://userweb.kernel.org/~akpm/stuff/added-to-mm.txt to find out what to do about this The current -mm tree may be found at http://userweb.kernel.org/~akpm/mmotm/ ------------------------------------------------------ Subject: Documentation/atomic_ops.txt: avoid volatile in sample code From: Nikanth Karthikesan <knikanth@xxxxxxx> As declaring counter as volatile is discouraged, it is best not to use it in sample code as well. Signed-off-by: Nikanth Karthikesan <knikanth@xxxxxxx> Signed-off-by: Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx> --- Documentation/atomic_ops.txt | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff -puN Documentation/atomic_ops.txt~documentation-atomic_opstxt-avoid-volatile-in-sample-code Documentation/atomic_ops.txt --- a/Documentation/atomic_ops.txt~documentation-atomic_opstxt-avoid-volatile-in-sample-code +++ a/Documentation/atomic_ops.txt @@ -12,7 +12,7 @@ Also, it should be made opaque such that C integer type will fail. Something like the following should suffice: - typedef struct { volatile int counter; } atomic_t; + typedef struct { int counter; } atomic_t; Historically, counter has been declared volatile. This is now discouraged. See Documentation/volatile-considered-harmful.txt for the complete rationale. _ Patches currently in -mm which might be from knikanth@xxxxxxx are documentation-atomic_opstxt-avoid-volatile-in-sample-code.patch -- To unsubscribe from this list: send the line "unsubscribe mm-commits" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html