The patch titled
mm: migration: clarify migrate_pages() comment
has been added to the -mm tree. Its filename is
mm-migration-clarify-migrate_pages-comment.patch
Before you just go and hit "reply", please:
a) Consider who else should be cc'ed
b) Prefer to cc a suitable mailing list as well
c) Ideally: find the original patch on the mailing list and do a
reply-to-all to that, adding suitable additional cc's
*** Remember to use Documentation/SubmitChecklist when testing your code ***
See http://userweb.kernel.org/~akpm/stuff/added-to-mm.txt to find
out what to do about this
The current -mm tree may be found at http://userweb.kernel.org/~akpm/mmotm/
------------------------------------------------------
Subject: mm: migration: clarify migrate_pages() comment
From: Minchan Kim <minchan.kim@xxxxxxxxx>
Callers of migrate_pages should putback_lru_pages to return pages isolated
to LRU or free list. Now comment is rather confusing. It says caller
always have to call it.
It is more clear to point out that the caller has to call it if
migrate_pages's return value isn't zero.
Signed-off-by: Minchan Kim <minchan.kim@xxxxxxxxx>
Cc: Christoph Lameter <cl@xxxxxxxxx>
Cc: Andrea Arcangeli <aarcange@xxxxxxxxxx>
Signed-off-by: Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx>
---
mm/migrate.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff -puN mm/migrate.c~mm-migration-clarify-migrate_pages-comment mm/migrate.c
--- a/mm/migrate.c~mm-migration-clarify-migrate_pages-comment
+++ a/mm/migrate.c
@@ -888,7 +888,7 @@ out:
* are movable anymore because to has become empty
* or no retryable pages exist anymore.
* Caller should call putback_lru_pages to return pages to the LRU
- * or free list.
+ * or free list only if ret != 0.
*
* Return: Number of pages not migrated or error code.
*/
_
Patches currently in -mm which might be from minchan.kim@xxxxxxxxx are
thp-fix-paravirt-x86-32bit-nopae.patch
linux-next.patch
mm-fix-deferred-congestion-timeout-if-preferred-zone-is-not-allowed.patch
mm-clear-pages_scanned-only-if-draining-a-pcp-adds-pages-to-the-buddy-allocator.patch
mm-migration-clarify-migrate_pages-comment.patch
mm-vmap-area-cache.patch
--
To unsubscribe from this list: send the line "unsubscribe mm-commits" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
