The patch titled
checkpatch: check for world-writeable sysfs/debugfs files
has been removed from the -mm tree. Its filename was
checkpatch-check-for-world-writeable-sysfs-debugfs-files.patch
This patch was dropped because it was merged into mainline or a subsystem tree
The current -mm tree may be found at http://userweb.kernel.org/~akpm/mmotm/
------------------------------------------------------
Subject: checkpatch: check for world-writeable sysfs/debugfs files
From: Dave Jones <davej@xxxxxxxxxx>
Exporting world writable sysfs/debugfs files is usually a bad thing. Warn
about it.
Signed-off-by: Dave Jones <davej@xxxxxxxxxx>
Cc: Andy Whitcroft <apw@xxxxxxxxxxxxx>
Signed-off-by: Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx>
---
scripts/checkpatch.pl | 5 +++++
1 file changed, 5 insertions(+)
diff -puN scripts/checkpatch.pl~checkpatch-check-for-world-writeable-sysfs-debugfs-files scripts/checkpatch.pl
--- a/scripts/checkpatch.pl~checkpatch-check-for-world-writeable-sysfs-debugfs-files
+++ a/scripts/checkpatch.pl
@@ -2897,6 +2897,11 @@ sub process {
ERROR("lockdep_no_validate class is reserved for device->mutex.\n" . $herecurr);
}
}
+
+ if ($line =~ /debugfs_create_file.*S_IWUGO/ ||
+ $line =~ /DEVICE_ATTR.*S_IWUGO/ ) {
+ WARN("Exporting world writable files is usually an error. Consider more restrictive permissions.\n" . $herecurr);
+ }
}
# If we have no input at all, then there is nothing to report on
_
Patches currently in -mm which might be from davej@xxxxxxxxxx are
origin.patch
linux-next.patch
sched-remove-long-deprecated-clone_stopped-flag.patch
--
To unsubscribe from this list: send the line "unsubscribe mm-commits" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
