The patch titled
drivers/leds/leds-h1940.c: use gpiolib for latch access, fix build failure
has been added to the -mm tree. Its filename is
leds-h1940-use-gpiolib-for-latch-access-fix-build-failure.patch
Before you just go and hit "reply", please:
a) Consider who else should be cc'ed
b) Prefer to cc a suitable mailing list as well
c) Ideally: find the original patch on the mailing list and do a
reply-to-all to that, adding suitable additional cc's
*** Remember to use Documentation/SubmitChecklist when testing your code ***
See http://userweb.kernel.org/~akpm/stuff/added-to-mm.txt to find
out what to do about this
The current -mm tree may be found at http://userweb.kernel.org/~akpm/mmotm/
------------------------------------------------------
Subject: drivers/leds/leds-h1940.c: use gpiolib for latch access, fix build failure
From: Peter Huewe <peterhuewe@xxxxxx>
Fix a build failure by converting leds-h1940.c to use gpiolib for latch
access introduced by 14477095abc6 ("ARM: h1940: Use gpiolib for latch
access").
drivers/leds/leds-h1940.c: In function 'h1940_greenled_set':
drivers/leds/leds-h1940.c:33: error: implicit declaration of function 'h1940_latch_control'
Unfortunately this driver was not converted back then.
Signed-off-by: Peter Huewe <peterhuewe@xxxxxx>
Cc: Vasily Khoruzhick <anarsoul@xxxxxxxxx>
Cc: Ben Dooks <ben-linux@xxxxxxxxx>
Cc: Vincent Sanders <support@xxxxxxxxxxxx>
Cc: Russell King <linux@xxxxxxxxxxxxxxxx>
Cc: Richard Purdie <rpurdie@xxxxxxxxx>
Cc: <stable@xxxxxxxxxx> [2.6.37.x]
Signed-off-by: Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx>
---
drivers/leds/leds-h1940.c | 20 ++++++++++----------
1 file changed, 10 insertions(+), 10 deletions(-)
diff -puN drivers/leds/leds-h1940.c~leds-h1940-use-gpiolib-for-latch-access-fix-build-failure drivers/leds/leds-h1940.c
--- a/drivers/leds/leds-h1940.c~leds-h1940-use-gpiolib-for-latch-access-fix-build-failure
+++ a/drivers/leds/leds-h1940.c
@@ -30,17 +30,17 @@ static void h1940_greenled_set(struct le
{
switch (value) {
case LED_HALF:
- h1940_latch_control(0, H1940_LATCH_LED_FLASH);
+ gpio_set_value(H1940_LATCH_LED_FLASH, 1);
s3c2410_gpio_setpin(S3C2410_GPA7, 1);
break;
case LED_FULL:
- h1940_latch_control(0, H1940_LATCH_LED_GREEN);
+ gpio_set_value(H1940_LATCH_LED_GREEN, 1);
s3c2410_gpio_setpin(S3C2410_GPA7, 1);
break;
default:
case LED_OFF:
- h1940_latch_control(H1940_LATCH_LED_FLASH, 0);
- h1940_latch_control(H1940_LATCH_LED_GREEN, 0);
+ gpio_set_value(H1940_LATCH_LED_FLASH, 0);
+ gpio_set_value(H1940_LATCH_LED_GREEN, 0);
s3c2410_gpio_setpin(S3C2410_GPA7, 0);
break;
}
@@ -60,17 +60,17 @@ static void h1940_redled_set(struct led_
{
switch (value) {
case LED_HALF:
- h1940_latch_control(0, H1940_LATCH_LED_FLASH);
+ gpio_set_value(H1940_LATCH_LED_FLASH, 1);
s3c2410_gpio_setpin(S3C2410_GPA1, 1);
break;
case LED_FULL:
- h1940_latch_control(0, H1940_LATCH_LED_RED);
+ gpio_set_value(H1940_LATCH_LED_RED, 1);
s3c2410_gpio_setpin(S3C2410_GPA1, 1);
break;
default:
case LED_OFF:
- h1940_latch_control(H1940_LATCH_LED_FLASH, 0);
- h1940_latch_control(H1940_LATCH_LED_RED, 0);
+ gpio_set_value(H1940_LATCH_LED_FLASH, 0);
+ gpio_set_value(H1940_LATCH_LED_RED, 0);
s3c2410_gpio_setpin(S3C2410_GPA1, 0);
break;
}
@@ -91,10 +91,10 @@ static void h1940_blueled_set(struct led
{
if (value) {
/* flashing Blue */
- h1940_latch_control(0, H1940_LATCH_LED_FLASH);
+ gpio_set_value(H1940_LATCH_LED_FLASH, 1);
s3c2410_gpio_setpin(S3C2410_GPA3, 1);
} else {
- h1940_latch_control(H1940_LATCH_LED_FLASH, 0);
+ gpio_set_value(H1940_LATCH_LED_FLASH, 0);
s3c2410_gpio_setpin(S3C2410_GPA3, 0);
}
_
Patches currently in -mm which might be from peterhuewe@xxxxxx are
origin.patch
linux-next.patch
leds-h1940-use-gpiolib-for-latch-access-fix-build-failure.patch
--
To unsubscribe from this list: send the line "unsubscribe mm-commits" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
