The patch titled
reiserfs: make sure va_end() is always called after va_start().
has been added to the -mm tree. Its filename is
reiserfs-make-sure-va_end-is-always-called-after-va_start.patch
Before you just go and hit "reply", please:
a) Consider who else should be cc'ed
b) Prefer to cc a suitable mailing list as well
c) Ideally: find the original patch on the mailing list and do a
reply-to-all to that, adding suitable additional cc's
*** Remember to use Documentation/SubmitChecklist when testing your code ***
See http://userweb.kernel.org/~akpm/stuff/added-to-mm.txt to find
out what to do about this
The current -mm tree may be found at http://userweb.kernel.org/~akpm/mmotm/
------------------------------------------------------
Subject: reiserfs: make sure va_end() is always called after va_start().
From: Jesper Juhl <jj@xxxxxxxxxxxxx>
A call to va_start() must always be followed by a call to va_end() in the
same function. In fs/reiserfs/prints.c::print_block() this is not always
the case. If 'bh' is NULL we'll return without calling va_end().
One could add a call to va_end() before the 'return' statement, but it's
nicer to just move the call to va_start() after the test for 'bh' being
NULL.
Signed-off-by: Jesper Juhl <jj@xxxxxxxxxxxxx>
Acked-by: Edward Shishkin <edward.shishkin@xxxxxxxxx>
Cc: Jeff Mahoney <jeffm@xxxxxxxx>
Signed-off-by: Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx>
---
fs/reiserfs/prints.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff -puN fs/reiserfs/prints.c~reiserfs-make-sure-va_end-is-always-called-after-va_start fs/reiserfs/prints.c
--- a/fs/reiserfs/prints.c~reiserfs-make-sure-va_end-is-always-called-after-va_start
+++ a/fs/reiserfs/prints.c
@@ -586,13 +586,13 @@ void print_block(struct buffer_head *bh,
va_list args;
int mode, first, last;
- va_start(args, bh);
-
if (!bh) {
printk("print_block: buffer is NULL\n");
return;
}
+ va_start(args, bh);
+
mode = va_arg(args, int);
first = va_arg(args, int);
last = va_arg(args, int);
_
Patches currently in -mm which might be from jj@xxxxxxxxxxxxx are
linux-next.patch
mm-hugetlbc-fix-error-path-memory-leak-in-nr_hugepages_store_common.patch
mm-hugetlbc-fix-error-path-memory-leak-in-nr_hugepages_store_common-fix.patch
gen_init_cpio-avoid-risk-of-file-changing-between-calls-to-stat-and-open-checkpatch-fixes.patch
befs-dont-pass-huge-structs-by-value.patch
reiserfs-make-sure-va_end-is-always-called-after-va_start.patch
memcg-use-zalloc-rather-than-mallocmemset.patch
--
To unsubscribe from this list: send the line "unsubscribe mm-commits" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
