+ pci-update-mcp55-quirk-to-not-affect-non-hypertransport-variants.patch added to -mm tree

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



The patch titled
     pci: update MCP55 quirk to not affect non HyperTransport variants
has been added to the -mm tree.  Its filename is
     pci-update-mcp55-quirk-to-not-affect-non-hypertransport-variants.patch

Before you just go and hit "reply", please:
   a) Consider who else should be cc'ed
   b) Prefer to cc a suitable mailing list as well
   c) Ideally: find the original patch on the mailing list and do a
      reply-to-all to that, adding suitable additional cc's

*** Remember to use Documentation/SubmitChecklist when testing your code ***

See http://userweb.kernel.org/~akpm/stuff/added-to-mm.txt to find
out what to do about this

The current -mm tree may be found at http://userweb.kernel.org/~akpm/mmotm/

------------------------------------------------------
Subject: pci: update MCP55 quirk to not affect non HyperTransport variants
From: Neil Horman <nhorman@xxxxxxxxxxxxx>

I wrote this quirk awhile ago to properly setup MCP55 chips on
hypertransport busses so that interrupts reached whatever cpu happend to
boot the kdump kernel.  while that works well, it was recently shown to me
that a a non-hypertransport variant of the MCP55 exists, and on those
system the register that this quirk manipulates causes hangs if you write
to it.  Since the quirk was only meant to handle errors found on MCP55
chips that have a HT interface, this patch adds a filter to make sure the
chip is an HT capable before making the needed register adjustment.  This
lets the broken MCP55s work with kdump while not breaking the non-HT
variants.

Addresses https://bugzilla.kernel.org/show_bug.cgi?id=23952

Tested successfully by the reporter and myself.

Reported-by: Mathieu Bérard <mathieu@xxxxxxxxxx>
Tested-by: Mathieu Bérard <mathieu@xxxxxxxxxx>
Cc: Vivek Goyal <vgoyal@xxxxxxxxxx>
Cc: Jesse Barnes <jbarnes@xxxxxxxxxxxxxxxx>
Signed-off-by: Neil Horman <nhorman@xxxxxxxxxxxxx>
Cc: <stable@xxxxxxxxxx>
Signed-off-by: Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx>
---

 drivers/pci/quirks.c |    3 +++
 1 file changed, 3 insertions(+)

diff -puN drivers/pci/quirks.c~pci-update-mcp55-quirk-to-not-affect-non-hypertransport-variants drivers/pci/quirks.c
--- a/drivers/pci/quirks.c~pci-update-mcp55-quirk-to-not-affect-non-hypertransport-variants
+++ a/drivers/pci/quirks.c
@@ -2329,6 +2329,9 @@ static void __devinit nvbridge_check_leg
 {
 	u32 cfg;
 
+	if (!pci_find_capability(dev, PCI_CAP_ID_HT))
+		return;
+
 	pci_read_config_dword(dev, 0x74, &cfg);
 
 	if (cfg & ((1 << 2) | (1 << 15))) {
_

Patches currently in -mm which might be from nhorman@xxxxxxxxxxxxx are

linux-next.patch
pci-update-mcp55-quirk-to-not-affect-non-hypertransport-variants.patch
fs-execc-provide-the-correct-process-pid-to-the-pipe-helper.patch

--
To unsubscribe from this list: send the line "unsubscribe mm-commits" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Kernel Newbies FAQ]     [Kernel Archive]     [IETF Annouce]     [DCCP]     [Netdev]     [Networking]     [Security]     [Bugtraq]     [Photo]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]

  Powered by Linux