The patch titled
logfs: fix "Kernel BUG at readwrite.c:1193"
has been added to the -mm tree. Its filename is
logfs-fix-kernel-bug-at-readwritec-1193.patch
Before you just go and hit "reply", please:
a) Consider who else should be cc'ed
b) Prefer to cc a suitable mailing list as well
c) Ideally: find the original patch on the mailing list and do a
reply-to-all to that, adding suitable additional cc's
*** Remember to use Documentation/SubmitChecklist when testing your code ***
See http://userweb.kernel.org/~akpm/stuff/added-to-mm.txt to find
out what to do about this
The current -mm tree may be found at http://userweb.kernel.org/~akpm/mmotm/
------------------------------------------------------
Subject: logfs: fix "Kernel BUG at readwrite.c:1193"
From: Prasad Joshi <prasadjoshi124@xxxxxxxxx>
This happens when __logfs_create() tries to write a new inode to the disk
which is full.
__logfs_create() associates the transaction pointer with inode. During
the logfs_write_inode() function call chain this transaction pointer is
moved from inode to page->private using function move_inode_to_page
(do_write_inode() -> inode_to_page() -> move_inode_to_page)
When the write inode fails, the transaction is aborted and iput is called
on the failed inode. During delete_inode the same transaction pointer
associated with the page is getting used. Thus causing kernel BUG.
The patch checks for error in write_inode() and restores the page->private
to NULL.
Addresses https://bugzilla.kernel.org/show_bug.cgi?id=20162
Signed-off-by: Prasad Joshi <prasadjoshi124@xxxxxxxxx>
Cc: Joern Engel <joern@xxxxxxxxx>
Cc: Florian Mickler <florian@xxxxxxxxxxx>
Cc: "Rafael J. Wysocki" <rjw@xxxxxxx>
Cc: Maciej Rutecki <maciej.rutecki@xxxxxxxxx>
Signed-off-by: Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx>
---
fs/logfs/readwrite.c | 3 +++
1 file changed, 3 insertions(+)
diff -puN fs/logfs/readwrite.c~logfs-fix-kernel-bug-at-readwritec-1193 fs/logfs/readwrite.c
--- a/fs/logfs/readwrite.c~logfs-fix-kernel-bug-at-readwritec-1193
+++ a/fs/logfs/readwrite.c
@@ -1994,6 +1994,9 @@ static int do_write_inode(struct inode *
/* FIXME: transaction is part of logfs_block now. Is that enough? */
err = logfs_write_buf(master_inode, page, 0);
+ if (err)
+ move_page_to_inode(inode, page);
+
logfs_put_write_page(page);
return err;
}
_
Patches currently in -mm which might be from prasadjoshi124@xxxxxxxxx are
logfs-fix-kernel-bug-at-readwritec-1193.patch
--
To unsubscribe from this list: send the line "unsubscribe mm-commits" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
