The patch titled
headers_check: better search for functions in headers
has been added to the -mm tree. Its filename is
headers_check-better-search-for-functions-in-headers.patch
Before you just go and hit "reply", please:
a) Consider who else should be cc'ed
b) Prefer to cc a suitable mailing list as well
c) Ideally: find the original patch on the mailing list and do a
reply-to-all to that, adding suitable additional cc's
*** Remember to use Documentation/SubmitChecklist when testing your code ***
See http://userweb.kernel.org/~akpm/stuff/added-to-mm.txt to find
out what to do about this
The current -mm tree may be found at http://userweb.kernel.org/~akpm/mmotm/
------------------------------------------------------
Subject: headers_check: better search for functions in headers
From: Alexander Shishkin <virtuoso@xxxxxxxxx>
Some headers don't bother with "extern" in function prototypes, which
results in said prototypes being unnoticed and exported to userland.
This patch slightly improves detection of such cases by checking for C
type names as well in the beginning of a line.
Signed-off-by: Alexander Shishkin <virtuoso@xxxxxxxxx>
Cc: Stephen Hemminger <shemminger@xxxxxxxxxx>
Cc: Michal Marek <mmarek@xxxxxxx>
Cc: WANG Cong <amwang@xxxxxxxxxx>
Cc: Randy Dunlap <randy.dunlap@xxxxxxxxxx>
Signed-off-by: Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx>
---
scripts/headers_check.pl | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff -puN scripts/headers_check.pl~headers_check-better-search-for-functions-in-headers scripts/headers_check.pl
--- a/scripts/headers_check.pl~headers_check-better-search-for-functions-in-headers
+++ a/scripts/headers_check.pl
@@ -64,7 +64,7 @@ sub check_include
sub check_declarations
{
- if ($line =~m/^\s*extern\b/) {
+ if ($line =~m/^(\s*extern|unsigned|char|short|int|long|void)\b/) {
printf STDERR "$filename:$lineno: " .
"userspace cannot call function or variable " .
"defined in the kernel\n";
_
Patches currently in -mm which might be from virtuoso@xxxxxxxxx are
headers_check-better-search-for-functions-in-headers.patch
--
To unsubscribe from this list: send the line "unsubscribe mm-commits" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
