The patch titled mm/page-writeback.c: fix __set_page_dirty_no_writeback() return value has been added to the -mm tree. Its filename is mm-page-writebackc-fix-__set_page_dirty_no_writeback-return-value.patch Before you just go and hit "reply", please: a) Consider who else should be cc'ed b) Prefer to cc a suitable mailing list as well c) Ideally: find the original patch on the mailing list and do a reply-to-all to that, adding suitable additional cc's *** Remember to use Documentation/SubmitChecklist when testing your code *** See http://userweb.kernel.org/~akpm/stuff/added-to-mm.txt to find out what to do about this The current -mm tree may be found at http://userweb.kernel.org/~akpm/mmotm/ ------------------------------------------------------ Subject: mm/page-writeback.c: fix __set_page_dirty_no_writeback() return value From: Bob Liu <lliubbo@xxxxxxxxx> __set_page_dirty_no_writeback() should return true if it actually transitioned the page from a clean to dirty state although it seems nobody uses its return value at present. Signed-off-by: Bob Liu <lliubbo@xxxxxxxxx> Acked-by: Wu Fengguang <fengguang.wu@xxxxxxxxx> Signed-off-by: Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx> --- mm/page-writeback.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff -puN mm/page-writeback.c~mm-page-writebackc-fix-__set_page_dirty_no_writeback-return-value mm/page-writeback.c --- a/mm/page-writeback.c~mm-page-writebackc-fix-__set_page_dirty_no_writeback-return-value +++ a/mm/page-writeback.c @@ -1103,7 +1103,7 @@ EXPORT_SYMBOL(write_one_page); int __set_page_dirty_no_writeback(struct page *page) { if (!PageDirty(page)) - SetPageDirty(page); + return !TestSetPageDirty(page); return 0; } _ Patches currently in -mm which might be from lliubbo@xxxxxxxxx are linux-next.patch mm-page-writebackc-fix-__set_page_dirty_no_writeback-return-value.patch -- To unsubscribe from this list: send the line "unsubscribe mm-commits" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html