+ lib-vsprintf-fix-invalid-arg-check.patch added to -mm tree

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



The patch titled
     lib/vsprintf.c: fix invalid arg check
has been added to the -mm tree.  Its filename is
     lib-vsprintf-fix-invalid-arg-check.patch

Before you just go and hit "reply", please:
   a) Consider who else should be cc'ed
   b) Prefer to cc a suitable mailing list as well
   c) Ideally: find the original patch on the mailing list and do a
      reply-to-all to that, adding suitable additional cc's

*** Remember to use Documentation/SubmitChecklist when testing your code ***

See http://userweb.kernel.org/~akpm/stuff/added-to-mm.txt to find
out what to do about this

The current -mm tree may be found at http://userweb.kernel.org/~akpm/mmotm/

------------------------------------------------------
Subject: lib/vsprintf.c: fix invalid arg check
From: Vasiliy Kulikov <segooon@xxxxxxxxx>

"size" is size_t.  If we want to check whether it was underflowed then we
should cast it to ssize_t instead of int.  When sizeof(size_t) >
sizeof(int) the code sees UINT_MAX as underflow, but it is not.

Signed-off-by: Vasiliy Kulikov <segooon@xxxxxxxxx>
Cc: Andr Goddard Rosa <andre.goddard@xxxxxxxxx>
Cc: Joe Perches <joe@xxxxxxxxxxx>
Cc: Frederic Weisbecker <fweisbec@xxxxxxxxx>
Cc: Bjorn Helgaas <bjorn.helgaas@xxxxxx>
Signed-off-by: Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx>
---

 lib/vsprintf.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff -puN lib/vsprintf.c~lib-vsprintf-fix-invalid-arg-check lib/vsprintf.c
--- a/lib/vsprintf.c~lib-vsprintf-fix-invalid-arg-check
+++ a/lib/vsprintf.c
@@ -1290,7 +1290,7 @@ int vsnprintf(char *buf, size_t size, co
 
 	/* Reject out-of-range values early.  Large positive sizes are
 	   used for unknown buffer sizes. */
-	if (WARN_ON_ONCE((int) size < 0))
+	if (WARN_ON_ONCE((ssize_t) size < 0))
 		return 0;
 
 	str = buf;
_

Patches currently in -mm which might be from segooon@xxxxxxxxx are

origin.patch
linux-next.patch
drivers-misc-apds9802alsc-fix-signedness-bug.patch
lib-vsprintf-fix-invalid-arg-check.patch
memstick-core-fix-device_register-error-handling.patch

--
To unsubscribe from this list: send the line "unsubscribe mm-commits" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Kernel Newbies FAQ]     [Kernel Archive]     [IETF Annouce]     [DCCP]     [Netdev]     [Networking]     [Security]     [Bugtraq]     [Photo]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]

  Powered by Linux