The patch titled
memcg: use native word to represent dirtyable pages
has been added to the -mm tree. Its filename is
memcg-add-dirty-limits-to-mem_cgroup-use-native-word-to-represent-dirtyable-pages.patch
Before you just go and hit "reply", please:
a) Consider who else should be cc'ed
b) Prefer to cc a suitable mailing list as well
c) Ideally: find the original patch on the mailing list and do a
reply-to-all to that, adding suitable additional cc's
*** Remember to use Documentation/SubmitChecklist when testing your code ***
See http://userweb.kernel.org/~akpm/stuff/added-to-mm.txt to find
out what to do about this
The current -mm tree may be found at http://userweb.kernel.org/~akpm/mmotm/
------------------------------------------------------
Subject: memcg: use native word to represent dirtyable pages
From: Johannes Weiner <hannes@xxxxxxxxxxx>
The memory cgroup dirty info calculation currently uses a signed 64-bit
type to represent the amount of dirtyable memory in pages.
This can instead be changed to an unsigned word, which will allow the
formula to function correctly with up to 160G of LRU pages on a 32-bit
system, assuming 4k pages. That should be plenty even when taking racy
folding of the per-cpu counters into account.
This fixes a compilation error on 32-bit systems as this code tries to do
64-bit division.
Signed-off-by: Johannes Weiner <hannes@xxxxxxxxxxx>
Reported-by: Dave Young <hidave.darkstar@xxxxxxxxx>
Reviewed-by: Greg Thelen <gthelen@xxxxxxxxxx>
Cc: Andrea Righi <arighi@xxxxxxxxxxx>
Cc: KAMEZAWA Hiroyuki <kamezawa.hiroyu@xxxxxxxxxxxxxx>
Cc: Daisuke Nishimura <nishimura@xxxxxxxxxxxxxxxxx>
Cc: Balbir Singh <balbir@xxxxxxxxxxxxxxxxxx>
Reviewed-by: Minchan Kim <minchan.kim@xxxxxxxxx>
Cc: Wu Fengguang <fengguang.wu@xxxxxxxxx>
Signed-off-by: Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx>
---
mm/memcontrol.c | 9 +++++----
1 file changed, 5 insertions(+), 4 deletions(-)
diff -puN mm/memcontrol.c~memcg-add-dirty-limits-to-mem_cgroup-use-native-word-to-represent-dirtyable-pages mm/memcontrol.c
--- a/mm/memcontrol.c~memcg-add-dirty-limits-to-mem_cgroup-use-native-word-to-represent-dirtyable-pages
+++ a/mm/memcontrol.c
@@ -1217,9 +1217,10 @@ static void __mem_cgroup_dirty_param(str
bool mem_cgroup_dirty_info(unsigned long sys_available_mem,
struct dirty_info *info)
{
- s64 available_mem;
struct vm_dirty_param dirty_param;
+ unsigned long available_mem;
struct mem_cgroup *memcg;
+ s64 value;
if (mem_cgroup_disabled())
return false;
@@ -1233,11 +1234,11 @@ bool mem_cgroup_dirty_info(unsigned long
__mem_cgroup_dirty_param(&dirty_param, memcg);
rcu_read_unlock();
- available_mem = mem_cgroup_page_stat(MEMCG_NR_DIRTYABLE_PAGES);
- if (available_mem < 0)
+ value = mem_cgroup_page_stat(MEMCG_NR_DIRTYABLE_PAGES);
+ if (value < 0)
return false;
- available_mem = min((unsigned long)available_mem, sys_available_mem);
+ available_mem = min((unsigned long)value, sys_available_mem);
if (dirty_param.dirty_bytes)
info->dirty_thresh =
_
Patches currently in -mm which might be from hannes@xxxxxxxxxxx are
memcg-add-dirty-limits-to-mem_cgroup-use-native-word-to-represent-dirtyable-pages.patch
memcg-add-dirty-limits-to-mem_cgroup-catch-negative-per-cpu-sums-in-dirty-info.patch
memcg-break-out-event-counters-from-other-stats.patch
memcg-use-native-word-page-statistics-counters.patch
--
To unsubscribe from this list: send the line "unsubscribe mm-commits" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
