The patch titled
drivers/char/mxser.c: fix compilation warning in mxser.c
has been added to the -mm tree. Its filename is
drivers-char-mxserc-fix-compilation-warning-in-mxserc.patch
Before you just go and hit "reply", please:
a) Consider who else should be cc'ed
b) Prefer to cc a suitable mailing list as well
c) Ideally: find the original patch on the mailing list and do a
reply-to-all to that, adding suitable additional cc's
*** Remember to use Documentation/SubmitChecklist when testing your code ***
See http://userweb.kernel.org/~akpm/stuff/added-to-mm.txt to find
out what to do about this
The current -mm tree may be found at http://userweb.kernel.org/~akpm/mmotm/
------------------------------------------------------
Subject: drivers/char/mxser.c: fix compilation warning in mxser.c
From: Rakib Mullick <rakib.mullick@xxxxxxxxx>
Both mxser_disable_must_enchance_mode() and mxser_get_must_hardware_id()
called from function CheckIsMoxaMust(), when CONFIG_PCI=y. So mark both
the functions under CONFIG_PCI.
We were warned by the following warning.
drivers/char/mxser.c:306: warning: ?mxser_disable_must_enchance_mode?
defined but not used
drivers/char/mxser.c:391: warning: ?mxser_get_must_hardware_id?
defined but not used
Signed-off-by: Rakib Mullick <rakib.mullick@xxxxxxxxx>
Cc: Jiri Slaby <jirislaby@xxxxxxxxx>
Signed-off-by: Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx>
---
drivers/char/mxser.c | 4 ++++
1 file changed, 4 insertions(+)
diff -puN drivers/char/mxser.c~drivers-char-mxserc-fix-compilation-warning-in-mxserc drivers/char/mxser.c
--- a/drivers/char/mxser.c~drivers-char-mxserc-fix-compilation-warning-in-mxserc
+++ a/drivers/char/mxser.c
@@ -303,6 +303,7 @@ static void mxser_enable_must_enchance_m
outb(oldlcr, baseio + UART_LCR);
}
+#ifdef CONFIG_PCI
static void mxser_disable_must_enchance_mode(unsigned long baseio)
{
u8 oldlcr;
@@ -317,6 +318,7 @@ static void mxser_disable_must_enchance_
outb(efr, baseio + MOXA_MUST_EFR_REGISTER);
outb(oldlcr, baseio + UART_LCR);
}
+#endif
static void mxser_set_must_xon1_value(unsigned long baseio, u8 value)
{
@@ -388,6 +390,7 @@ static void mxser_set_must_enum_value(un
outb(oldlcr, baseio + UART_LCR);
}
+#ifdef CONFIG_PCI
static void mxser_get_must_hardware_id(unsigned long baseio, u8 *pId)
{
u8 oldlcr;
@@ -404,6 +407,7 @@ static void mxser_get_must_hardware_id(u
*pId = inb(baseio + MOXA_MUST_HWID_REGISTER);
outb(oldlcr, baseio + UART_LCR);
}
+#endif
static void SET_MOXA_MUST_NO_SOFTWARE_FLOW_CONTROL(unsigned long baseio)
{
_
Patches currently in -mm which might be from rakib.mullick@xxxxxxxxx are
linux-next.patch
kernel-stop_machinec-fix-unused-variable-warning.patch
drivers-char-mxserc-fix-compilation-warning-in-mxserc.patch
--
To unsubscribe from this list: send the line "unsubscribe mm-commits" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
