On Fri, 08 Oct 2010 00:06:49 +0200 Jiri Slaby <jirislaby@xxxxxxxxx> wrote: > On 10/07/2010 11:08 PM, akpm@xxxxxxxxxxxxxxxxxxxx wrote: > > The mm-of-the-moment snapshot 2010-10-07-14-08 has been uploaded to > > Hi, I got bunch of "sysctl table check failed" below. All seem to be > related to ipv4: > > sysctl table check failed: /net/ipv4/tcp_mem No min > Pid: 1, comm: swapper Not tainted 2.6.36-rc7-mm1_64+ #1285 > Call Trace: > [<ffffffff8108d444>] set_fail+0xa4/0xf0 > [<ffffffff8108d736>] sysctl_check_table+0x2a6/0x310 > [<ffffffff8108d4eb>] sysctl_check_table+0x5b/0x310 > [<ffffffff8108d4eb>] sysctl_check_table+0x5b/0x310 > [<ffffffff81072204>] __register_sysctl_paths+0xf4/0x320 > [<ffffffff815c1232>] ? printk+0x3c/0x42 > [<ffffffff8115d3bc>] ? sysfs_add_file+0xc/0x10 > [<ffffffff818b18bd>] ? sysctl_ipv4_init+0x0/0x87 > [<ffffffff81072456>] register_sysctl_paths+0x26/0x30 > [<ffffffff818b18fd>] sysctl_ipv4_init+0x40/0x87 > [<ffffffff810002df>] do_one_initcall+0x3f/0x170 > [<ffffffff81884d44>] kernel_init+0x158/0x1e2 > [<ffffffff8102fb54>] kernel_thread_helper+0x4/0x10 > [<ffffffff81884bec>] ? kernel_init+0x0/0x1e2 > [<ffffffff8102fb50>] ? kernel_thread_helper+0x0/0x10 OK, thanks. Eric D's net-avoid-limits-overflow.patch switched tcp_mem and udp_mem from proc_dointvec() to proc_doulongvec_minmax(). And sysctl_check_table() checks `min' and `max' for proc_doulongvec_minmax() but not for proc_dointvec(). I'm not sure which Eric to blame ;) .min and .max are optional, so perhaps the check is wrong? -- To unsubscribe from this list: send the line "unsubscribe mm-commits" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
