The patch titled
cciss: fix botched tag masking for scsi tape commands
has been added to the -mm tree. Its filename is
cciss-fix-botched-tag-masking-for-scsi-tape-commands.patch
Before you just go and hit "reply", please:
a) Consider who else should be cc'ed
b) Prefer to cc a suitable mailing list as well
c) Ideally: find the original patch on the mailing list and do a
reply-to-all to that, adding suitable additional cc's
*** Remember to use Documentation/SubmitChecklist when testing your code ***
See http://userweb.kernel.org/~akpm/stuff/added-to-mm.txt to find
out what to do about this
The current -mm tree may be found at http://userweb.kernel.org/~akpm/mmotm/
------------------------------------------------------
Subject: cciss: fix botched tag masking for scsi tape commands
From: Stephen M. Cameron <scameron@xxxxxxxxxxxxxxxxxx>
In process_non_indexed_cmd() we were only masking off the low two bits
when comparing tags vs. busaddr, and not taking into account the fact
that in "performant" mode, three bits of block fetch table indexes were
stuffed into the tag, and needed to be masked out for the comparison to
work.
This resulted in spurious "bad tag" messages, and command completions
getting ignored for any scsi tape i/o and any i/o coming through
CCISS_BIG_PASSTHRU which required more than one scatter gather entry
(fewer than two worked because in such cases the 3 bits we failed to mask
off happened to be zero anyway.)
I also noticed we were repeatedly masking the bits off the tag in a loop
when doing it once at the top of the loop would have sufficed, so I fixed
that as well.
Signed-off-by: Stephen M. Cameron <scameron@xxxxxxxxxxxxxxxxxx>
Cc: Jens Axboe <axboe@xxxxxxxxx>
Signed-off-by: Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx>
---
drivers/block/cciss.c | 15 ++++++++-------
1 file changed, 8 insertions(+), 7 deletions(-)
diff -puN drivers/block/cciss.c~cciss-fix-botched-tag-masking-for-scsi-tape-commands drivers/block/cciss.c
--- a/drivers/block/cciss.c~cciss-fix-botched-tag-masking-for-scsi-tape-commands
+++ a/drivers/block/cciss.c
@@ -3163,10 +3163,13 @@ static inline u32 cciss_tag_to_index(u32
return tag >> DIRECT_LOOKUP_SHIFT;
}
-static inline u32 cciss_tag_discard_error_bits(u32 tag)
+static inline u32 cciss_tag_discard_error_bits(ctlr_info_t *h, u32 tag)
{
-#define CCISS_ERROR_BITS 0x03
- return tag & ~CCISS_ERROR_BITS;
+#define CCISS_PERF_ERROR_BITS ((1 << DIRECT_LOOKUP_SHIFT) - 1)
+#define CCISS_SIMPLE_ERROR_BITS 0x03
+ if (likely(h->transMethod == CFGTBL_Trans_Performant))
+ return tag & ~CCISS_PERF_ERROR_BITS;
+ return tag & ~CCISS_SIMPLE_ERROR_BITS;
}
static inline void cciss_mark_tag_indexed(u32 *tag)
@@ -3427,15 +3430,13 @@ static inline u32 process_indexed_cmd(ct
/* process completion of a non-indexed command */
static inline u32 process_nonindexed_cmd(ctlr_info_t *h, u32 raw_tag)
{
- u32 tag;
CommandList_struct *c = NULL;
struct hlist_node *tmp;
__u32 busaddr_masked, tag_masked;
- tag = cciss_tag_discard_error_bits(raw_tag);
+ tag_masked = cciss_tag_discard_error_bits(h, raw_tag);
hlist_for_each_entry(c, tmp, &h->cmpQ, list) {
- busaddr_masked = cciss_tag_discard_error_bits(c->busaddr);
- tag_masked = cciss_tag_discard_error_bits(tag);
+ busaddr_masked = cciss_tag_discard_error_bits(h, c->busaddr);
if (busaddr_masked == tag_masked) {
finish_cmd(h, c, raw_tag);
return next_command(h);
_
Patches currently in -mm which might be from scameron@xxxxxxxxxxxxxxxxxx are
linux-next.patch
cciss-fix-botched-tag-masking-for-scsi-tape-commands.patch
--
To unsubscribe from this list: send the line "unsubscribe mm-commits" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
