The patch titled drivers/rtc/rtc-ab3100.c: add missing platform_set_drvdata() in ab3100_rtc_probe() has been added to the -mm tree. Its filename is drivers-rtc-rtc-ab3100c-add-missing-platform_set_drvdata-in-ab3100_rtc_probe.patch Before you just go and hit "reply", please: a) Consider who else should be cc'ed b) Prefer to cc a suitable mailing list as well c) Ideally: find the original patch on the mailing list and do a reply-to-all to that, adding suitable additional cc's *** Remember to use Documentation/SubmitChecklist when testing your code *** See http://userweb.kernel.org/~akpm/stuff/added-to-mm.txt to find out what to do about this The current -mm tree may be found at http://userweb.kernel.org/~akpm/mmotm/ ------------------------------------------------------ Subject: drivers/rtc/rtc-ab3100.c: add missing platform_set_drvdata() in ab3100_rtc_probe() From: Axel Lin <axel.lin@xxxxxxxxx> Otherwise, calling platform_get_drvdata() in ab3100_rtc_remove() returns NULL. Signed-off-by: Axel Lin <axel.lin@xxxxxxxxx> Acked-by:Wan ZongShun <mcuos.com@xxxxxxxxx> Acked-by: Linus Walleij <linus.walleij@xxxxxxxxxxxxxx> Cc: Alessandro Zummo <a.zummo@xxxxxxxxxxxx> Signed-off-by: Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx> --- drivers/rtc/rtc-ab3100.c | 2 ++ 1 file changed, 2 insertions(+) diff -puN drivers/rtc/rtc-ab3100.c~drivers-rtc-rtc-ab3100c-add-missing-platform_set_drvdata-in-ab3100_rtc_probe drivers/rtc/rtc-ab3100.c --- a/drivers/rtc/rtc-ab3100.c~drivers-rtc-rtc-ab3100c-add-missing-platform_set_drvdata-in-ab3100_rtc_probe +++ a/drivers/rtc/rtc-ab3100.c @@ -235,6 +235,7 @@ static int __init ab3100_rtc_probe(struc err = PTR_ERR(rtc); return err; } + platform_set_drvdata(pdev, rtc); return 0; } @@ -244,6 +245,7 @@ static int __exit ab3100_rtc_remove(stru struct rtc_device *rtc = platform_get_drvdata(pdev); rtc_device_unregister(rtc); + platform_set_drvdata(pdev, NULL); return 0; } _ Patches currently in -mm which might be from axel.lin@xxxxxxxxx are drivers-rtc-rtc-ab3100c-add-missing-platform_set_drvdata-in-ab3100_rtc_probe.patch linux-next.patch drivers-video-backlight-s6e63m0c-set-permissions-on-gamma_table-file-to-0444.patch backlight-s6e63m0-unregister-backlight-device-and-remove-sysfs-attribute-file-in-s6e63m0_remove.patch backlight-s6e63m0-fix-section-mismatch.patch -- To unsubscribe from this list: send the line "unsubscribe mm-commits" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html