The patch titled drivers/char/nozomi.c: prevent reading uninitialized stack memory has been added to the -mm tree. Its filename is drivers-char-nozomic-prevent-reading-uninitialized-stack-memory.patch Before you just go and hit "reply", please: a) Consider who else should be cc'ed b) Prefer to cc a suitable mailing list as well c) Ideally: find the original patch on the mailing list and do a reply-to-all to that, adding suitable additional cc's *** Remember to use Documentation/SubmitChecklist when testing your code *** See http://userweb.kernel.org/~akpm/stuff/added-to-mm.txt to find out what to do about this The current -mm tree may be found at http://userweb.kernel.org/~akpm/mmotm/ ------------------------------------------------------ Subject: drivers/char/nozomi.c: prevent reading uninitialized stack memory From: Dan Rosenberg <drosenberg@xxxxxxxxxxxxx> The TIOCGICOUNT device ioctl allows unprivileged users to read uninitialized stack memory, because the "reserved" member of the serial_icounter_struct struct declared on the stack is not altered or zeroed before being copied back to the user. This patch takes care of it. Signed-off-by: Dan Rosenberg <dan.j.rosenberg@xxxxxxxxx> Cc: Alan Cox <alan@xxxxxxxxxxxxxxxxxxx> Cc: Greg KH <greg@xxxxxxxxx> Signed-off-by: Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx> --- drivers/char/nozomi.c | 2 ++ 1 file changed, 2 insertions(+) diff -puN drivers/char/nozomi.c~drivers-char-nozomic-prevent-reading-uninitialized-stack-memory drivers/char/nozomi.c --- a/drivers/char/nozomi.c~drivers-char-nozomic-prevent-reading-uninitialized-stack-memory +++ a/drivers/char/nozomi.c @@ -1809,6 +1809,8 @@ static int ntty_ioctl_tiocgicount(struct const struct async_icount cnow = port->tty_icount; struct serial_icounter_struct icount; + memset(&icount, 0, sizeof(struct serial_icounter_struct)); + icount.cts = cnow.cts; icount.dsr = cnow.dsr; icount.rng = cnow.rng; _ Patches currently in -mm which might be from drosenberg@xxxxxxxxxxxxx are linux-next.patch drivers-serial-serial_corec-prevent-reading-uninitialized-stack-memory.patch drivers-char-amiserialc-prevent-reading-uninitialized-stack-memory.patch drivers-char-nozomic-prevent-reading-uninitialized-stack-memory.patch -- To unsubscribe from this list: send the line "unsubscribe mm-commits" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html