The patch titled drivers/atm/firestream.c: fix unsigned return type has been added to the -mm tree. Its filename is drivers-atm-firestreamc-fix-unsigned-return-type.patch Before you just go and hit "reply", please: a) Consider who else should be cc'ed b) Prefer to cc a suitable mailing list as well c) Ideally: find the original patch on the mailing list and do a reply-to-all to that, adding suitable additional cc's *** Remember to use Documentation/SubmitChecklist when testing your code *** See http://userweb.kernel.org/~akpm/stuff/added-to-mm.txt to find out what to do about this The current -mm tree may be found at http://userweb.kernel.org/~akpm/mmotm/ ------------------------------------------------------ Subject: drivers/atm/firestream.c: fix unsigned return type From: Julia Lawall <julia@xxxxxxx> The function has an unsigned return type, but returns a negative constant to indicate an error condition. The result of calling the function is always stored in a variable of type (signed) int, and thus unsigned can be dropped from the return type. A sematic match that finds this problem is as follows: (http://coccinelle.lip6.fr/) // <smpl> @exists@ identifier f; constant C; @@ unsigned f(...) { <+... * return -C; ...+> } // </smpl> Signed-off-by: Julia Lawall <julia@xxxxxxx> Signed-off-by: Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx> --- drivers/atm/firestream.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff -puN drivers/atm/firestream.c~drivers-atm-firestreamc-fix-unsigned-return-type drivers/atm/firestream.c --- a/drivers/atm/firestream.c~drivers-atm-firestreamc-fix-unsigned-return-type +++ a/drivers/atm/firestream.c @@ -444,8 +444,8 @@ static inline void fs_kfree_skb (struct #define ROUND_NEAREST 3 /********** make rate (not quite as much fun as Horizon) **********/ -static unsigned int make_rate (unsigned int rate, int r, - u16 * bits, unsigned int * actual) +static int make_rate(unsigned int rate, int r, + u16 *bits, unsigned int *actual) { unsigned char exp = -1; /* hush gcc */ unsigned int man = -1; /* hush gcc */ _ Patches currently in -mm which might be from julia@xxxxxxx are linux-next.patch drivers-mmc-host-imxmmcc-adjust-confusing-if-indentation.patch fs-btrfs-use-memdup_user.patch fs-btrfs-use-err_cast.patch drivers-video-matrox-matroxfb_mavenc-fix-unsigned-return-type.patch arch-x86-kernel-cpu-cpufreq-fix-unsigned-return-type.patch net-9p-trans_fdc-fix-unsigned-return-type.patch drivers-i2c-busses-i2c-pasemic-fix-unsigned-return-type.patch drivers-atm-firestreamc-fix-unsigned-return-type.patch drivers-net-wireless-iwlwifi-iwl-agnc-fix-return-value-from-an-unsigned-function.patch -- To unsubscribe from this list: send the line "unsubscribe mm-commits" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html