The patch titled ip2: return -EFAULT on copy_to_user errors has been added to the -mm tree. Its filename is ip2-return-efault-on-copy_to_user-errors.patch Before you just go and hit "reply", please: a) Consider who else should be cc'ed b) Prefer to cc a suitable mailing list as well c) Ideally: find the original patch on the mailing list and do a reply-to-all to that, adding suitable additional cc's *** Remember to use Documentation/SubmitChecklist when testing your code *** See http://userweb.kernel.org/~akpm/stuff/added-to-mm.txt to find out what to do about this The current -mm tree may be found at http://userweb.kernel.org/~akpm/mmotm/ ------------------------------------------------------ Subject: ip2: return -EFAULT on copy_to_user errors From: Dan Carpenter <error27@xxxxxxxxx> copy_to_user() returns the number of bytes remaining but we want to return a negative error code on errors. Signed-off-by: Dan Carpenter <error27@xxxxxxxxx> Cc: "Michael H. Warfield" <mhw@xxxxxxxxxxxx> Cc: Greg KH <greg@xxxxxxxxx> Signed-off-by: Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx> --- drivers/char/ip2/ip2main.c | 2 ++ 1 file changed, 2 insertions(+) diff -puN drivers/char/ip2/ip2main.c~ip2-return-efault-on-copy_to_user-errors drivers/char/ip2/ip2main.c --- a/drivers/char/ip2/ip2main.c~ip2-return-efault-on-copy_to_user-errors +++ a/drivers/char/ip2/ip2main.c @@ -2930,6 +2930,8 @@ ip2_ipl_ioctl (struct file *pFile, UINT if ( pCh ) { rc = copy_to_user(argp, pCh, sizeof(i2ChanStr)); + if (rc) + rc = -EFAULT; } else { rc = -ENODEV; } _ Patches currently in -mm which might be from error27@xxxxxxxxx are origin.patch linux-next.patch ip2-remove-unneeded-null-check.patch ip2-return-efault-on-copy_to_user-errors.patch -- To unsubscribe from this list: send the line "unsubscribe mm-commits" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html