The patch titled drivers/video/igafb.c: introduce lost 'return' has been added to the -mm tree. Its filename is drivers-video-igafbc-introduce-lost-return.patch Before you just go and hit "reply", please: a) Consider who else should be cc'ed b) Prefer to cc a suitable mailing list as well c) Ideally: find the original patch on the mailing list and do a reply-to-all to that, adding suitable additional cc's *** Remember to use Documentation/SubmitChecklist when testing your code *** See http://userweb.kernel.org/~akpm/stuff/added-to-mm.txt to find out what to do about this The current -mm tree may be found at http://userweb.kernel.org/~akpm/mmotm/ ------------------------------------------------------ Subject: drivers/video/igafb.c: introduce lost 'return' From: Kulikov Vasiliy <segooon@xxxxxxxxx> If iga_init() fails, code releases resources and continues to use it. It seems that after releasing resources 'return' should be. Signed-off-by: Kulikov Vasiliy <segooon@xxxxxxxxx> Signed-off-by: Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx> --- drivers/video/igafb.c | 1 + 1 file changed, 1 insertion(+) diff -puN drivers/video/igafb.c~drivers-video-igafbc-introduce-lost-return drivers/video/igafb.c --- a/drivers/video/igafb.c~drivers-video-igafbc-introduce-lost-return +++ a/drivers/video/igafb.c @@ -531,6 +531,7 @@ int __init igafb_init(void) iounmap(info->screen_base); kfree(par->mmap_map); kfree(info); + return -ENODEV; } #ifdef CONFIG_SPARC _ Patches currently in -mm which might be from segooon@xxxxxxxxx are linux-next.patch cpqarray-check-put_user-result.patch mm-vmallocc-check-kmalloc-return-value.patch i2o-fix-overflow-of-copy_to_user.patch i2o-check-return-code-from-put_user.patch drivers-video-igafbc-introduce-lost-return.patch edac-i5000-improve-handling-of-pci_enable_device-return-value.patch edac-i5400-improve-handling-of-pci_enable_device-return-value.patch -- To unsubscribe from this list: send the line "unsubscribe mm-commits" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html