The patch titled char: mxser: remove unnesesary NULL check has been added to the -mm tree. Its filename is char-mxser-remove-unnesesary-null-check.patch Before you just go and hit "reply", please: a) Consider who else should be cc'ed b) Prefer to cc a suitable mailing list as well c) Ideally: find the original patch on the mailing list and do a reply-to-all to that, adding suitable additional cc's *** Remember to use Documentation/SubmitChecklist when testing your code *** See http://userweb.kernel.org/~akpm/stuff/added-to-mm.txt to find out what to do about this The current -mm tree may be found at http://userweb.kernel.org/~akpm/mmotm/ ------------------------------------------------------ Subject: char: mxser: remove unnesesary NULL check From: Kulikov Vasiliy <segooon@xxxxxxxxx> mxser_transmit_chars(tty, port) is called only from mxser_interrupt(). NULL check is performed in mxser_interrupt() so it is redundant here. Signed-off-by: Kulikov Vasiliy <segooon@xxxxxxxxx> Acked-by: Jiri Slaby <jirislaby@xxxxxxxxx> Signed-off-by: Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx> --- drivers/char/mxser.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff -puN drivers/char/mxser.c~char-mxser-remove-unnesesary-null-check drivers/char/mxser.c --- a/drivers/char/mxser.c~char-mxser-remove-unnesesary-null-check +++ a/drivers/char/mxser.c @@ -2193,7 +2193,7 @@ static void mxser_transmit_chars(struct port->mon_data.up_txcnt += (cnt - port->xmit_cnt); port->icount.tx += (cnt - port->xmit_cnt); - if (port->xmit_cnt < WAKEUP_CHARS && tty) + if (port->xmit_cnt < WAKEUP_CHARS) tty_wakeup(tty); if (port->xmit_cnt <= 0) { _ Patches currently in -mm which might be from segooon@xxxxxxxxx are linux-next.patch i2o-fix-overflow-of-copy_to_user.patch i2o-check-return-code-from-put_user.patch char-mxser-remove-unnesesary-null-check.patch edac-i5000-improve-handling-of-pci_enable_device-return-value.patch edac-i5400-improve-handling-of-pci_enable_device-return-value.patch -- To unsubscribe from this list: send the line "unsubscribe mm-commits" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html