The patch titled writeback: fix queue_io() ordering has been added to the -mm tree. Its filename is writeback-fix-queue_io-ordering.patch Before you just go and hit "reply", please: a) Consider who else should be cc'ed b) Prefer to cc a suitable mailing list as well c) Ideally: find the original patch on the mailing list and do a reply-to-all to that, adding suitable additional cc's *** Remember to use Documentation/SubmitChecklist when testing your code *** See http://userweb.kernel.org/~akpm/stuff/added-to-mm.txt to find out what to do about this The current -mm tree may be found at http://userweb.kernel.org/~akpm/mmotm/ ------------------------------------------------------ Subject: writeback: fix queue_io() ordering From: Wu Fengguang <fengguang.wu@xxxxxxxxx> This was not a bug, since b_io is empty for kupdate writeback. The next patch will do requeue_io() for non-kupdate writeback, so let's fix it. Signed-off-by: Wu Fengguang <fengguang.wu@xxxxxxxxx> Cc: Dave Chinner <david@xxxxxxxxxxxxx> Cc: Martin Bligh <mbligh@xxxxxxxxxx> Cc: Michael Rubin <mrubin@xxxxxxxxxx> Cc: Peter Zijlstra <peterz@xxxxxxxxxxxxx> Cc: Christoph Hellwig <hch@xxxxxxxxxxxxx> Cc: Jens Axboe <axboe@xxxxxxxxx> Signed-off-by: Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx> --- fs/fs-writeback.c | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) diff -puN fs/fs-writeback.c~writeback-fix-queue_io-ordering fs/fs-writeback.c --- a/fs/fs-writeback.c~writeback-fix-queue_io-ordering +++ a/fs/fs-writeback.c @@ -251,11 +251,14 @@ static void move_expired_inodes(struct l } /* - * Queue all expired dirty inodes for io, eldest first. + * Queue all expired dirty inodes for io, eldest first: + * (newly dirtied) => b_dirty inodes + * => b_more_io inodes + * => remaining inodes in b_io => (dequeue for sync) */ static void queue_io(struct bdi_writeback *wb, unsigned long *older_than_this) { - list_splice_init(&wb->b_more_io, wb->b_io.prev); + list_splice_init(&wb->b_more_io, &wb->b_io); move_expired_inodes(&wb->b_dirty, &wb->b_io, older_than_this); } _ Patches currently in -mm which might be from fengguang.wu@xxxxxxxxx are origin.patch linux-next.patch include-linux-fsh-complete-hexification-of-fmode_-constants.patch vfs-o_-bit-numbers-uniqueness-check.patch vfs-introduce-fmode_neg_offset-for-allowing-negative-f_pos.patch writeback-take-account-of-nr_writeback_temp-in-balance_dirty_pages.patch writeback-reduce-calls-to-global_page_state-in-balance_dirty_pages.patch writeback-avoid-unnecessary-calculation-of-bdi-dirty-thresholds.patch writeback-dont-redirty-tail-an-inode-with-dirty-pages.patch writeback-fix-queue_io-ordering.patch writeback-merge-for_kupdate-and-for_kupdate-cases.patch vfs-add-super-operation-writeback_inodes.patch -- To unsubscribe from this list: send the line "unsubscribe mm-commits" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html