The patch titled
vfs: attr, check ATTR_SIZE in ia_valid not ia_mode
has been added to the -mm tree. Its filename is
vfs-attr-check-attr_size-in-ia_valid-not-ia_mode.patch
Before you just go and hit "reply", please:
a) Consider who else should be cc'ed
b) Prefer to cc a suitable mailing list as well
c) Ideally: find the original patch on the mailing list and do a
reply-to-all to that, adding suitable additional cc's
*** Remember to use Documentation/SubmitChecklist when testing your code ***
See http://userweb.kernel.org/~akpm/stuff/added-to-mm.txt to find
out what to do about this
The current -mm tree may be found at http://userweb.kernel.org/~akpm/mmotm/
------------------------------------------------------
Subject: vfs: attr, check ATTR_SIZE in ia_valid not ia_mode
From: Jiri Slaby <jslaby@xxxxxxx>
Fix a bug introduced by linux-next commit "check ATTR_SIZE contraints in
inode_change_ok" which added a size check, but checks the size even if
ATTR_SIZE is not in attr->ia_valid because it tests the bit in
attr->ia_mode.
Test properly against ia_valid.
Signed-off-by: Jiri Slaby <jslaby@xxxxxxx>
Cc: Christoph Hellwig <hch@xxxxxx>
Cc: Al Viro <viro@xxxxxxxxxxxxxxxxxx>
Signed-off-by: Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx>
---
fs/attr.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff -puN fs/attr.c~vfs-attr-check-attr_size-in-ia_valid-not-ia_mode fs/attr.c
--- a/fs/attr.c~vfs-attr-check-attr_size-in-ia_valid-not-ia_mode
+++ a/fs/attr.c
@@ -34,7 +34,7 @@ int inode_change_ok(const struct inode *
* First check size constraints. These can't be overriden using
* ATTR_FORCE.
*/
- if (attr->ia_mode & ATTR_SIZE) {
+ if (ia_valid & ATTR_SIZE) {
int error = inode_newsize_ok(inode, attr->ia_size);
if (error)
return error;
_
Patches currently in -mm which might be from jslaby@xxxxxxx are
cpuidle-avoid-using-smp_processor_id-in-preemptible-code-nr_iowait_cpu.patch
cpuidle-avoid-using-smp_processor_id-in-preemptible-code-nr_iowait_cpu-v4.patch
cpuidle-avoid-using-smp_processor_id-in-preemptible-code-nr_iowait_cpu-v4-fix.patch
cpuidle-avoid-using-smp_processor_id-in-preemptible-code-nr_iowait_cpu-v4-fix-fix.patch
cpuidle-avoid-using-smp_processor_id-in-preemptible-code-nr_iowait_cpu-v4-fix-fix-fix.patch
leds-route-kbd-leds-through-the-generic-leds-layer-fix-sleep-inside-atomic.patch
vfs-attr-check-attr_size-in-ia_valid-not-ia_mode.patch
vfs-use-kmalloc-to-allocate-fdmem-if-possible.patch
--
To unsubscribe from this list: send the line "unsubscribe mm-commits" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
