The patch titled drivers/md/dm-mpath.c: fix kernel NULL pointer dereference has been added to the -mm tree. Its filename is drivers-md-dm-mpathc-fix-kernel-null-pointer-dereference.patch Before you just go and hit "reply", please: a) Consider who else should be cc'ed b) Prefer to cc a suitable mailing list as well c) Ideally: find the original patch on the mailing list and do a reply-to-all to that, adding suitable additional cc's *** Remember to use Documentation/SubmitChecklist when testing your code *** See http://userweb.kernel.org/~akpm/stuff/added-to-mm.txt to find out what to do about this The current -mm tree may be found at http://userweb.kernel.org/~akpm/mmotm/ ------------------------------------------------------ Subject: drivers/md/dm-mpath.c: fix kernel NULL pointer dereference From: "Patrick J. LoPresti" <lopresti@xxxxxxxxx> I discovered this when I accidentally put the following in my /etc/multipath.conf file: path_selector least_pending ...instead of this: path_selector "least_pending 0" To my surprise, this resulted in a NULL pointer dereference in the kernel. Without this patch, the parse_priority_group function can return 0, which the caller (multipath_ctr()) immediately dereferences. Cc: Alasdair G Kergon <agk@xxxxxxxxxx> Signed-off-by: Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx> --- drivers/md/dm-mpath.c | 1 + 1 file changed, 1 insertion(+) diff -puN drivers/md/dm-mpath.c~drivers-md-dm-mpathc-fix-kernel-null-pointer-dereference drivers/md/dm-mpath.c --- a/drivers/md/dm-mpath.c~drivers-md-dm-mpathc-fix-kernel-null-pointer-dereference +++ a/drivers/md/dm-mpath.c @@ -706,6 +706,7 @@ static struct priority_group *parse_prio if (as->argc < nr_params) { ti->error = "not enough path parameters"; + r = -EINVAL; goto bad; } _ Patches currently in -mm which might be from lopresti@xxxxxxxxx are drivers-md-dm-mpathc-fix-kernel-null-pointer-dereference.patch -- To unsubscribe from this list: send the line "unsubscribe mm-commits" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html