The patch titled
compiler-gcc.h: gcc-4.5 needs noclone and noinline on __naked functions
has been added to the -mm tree. Its filename is
compiler-gcch-gcc-45-needs-noclone-and-noinline-on-__naked-functions.patch
Before you just go and hit "reply", please:
a) Consider who else should be cc'ed
b) Prefer to cc a suitable mailing list as well
c) Ideally: find the original patch on the mailing list and do a
reply-to-all to that, adding suitable additional cc's
*** Remember to use Documentation/SubmitChecklist when testing your code ***
See http://userweb.kernel.org/~akpm/stuff/added-to-mm.txt to find
out what to do about this
The current -mm tree may be found at http://userweb.kernel.org/~akpm/mmotm/
------------------------------------------------------
Subject: compiler-gcc.h: gcc-4.5 needs noclone and noinline on __naked functions
From: Mikael Pettersson <mikpe@xxxxxxxx>
A __naked function is defined in C but with a body completely implemented
by asm(), including any prologue and epilogue. These asm() bodies expect
standard calling conventions for parameter passing. Older GCCs implement
that correctly, but 4.[56] currently do not, see GCC PR44290. In the
Linux kernel this breaks ARM, causing most arch/arm/mm/copypage-*.c
modules to get miscompiled, resulting in kernel crashes during bootup.
Part of the kernel fix is to augment the __naked function attribute to
also imply noinline and noclone. This patch implements that, and has been
verified to fix boot failures with gcc-4.5 compiled 2.6.34 and 2.6.35-rc1
kernels. The patch is a no-op with older GCCs.
Signed-off-by: Mikael Pettersson <mikpe@xxxxxxxx>
Signed-off-by: Khem Raj <raj.khem@xxxxxxxxx>
Cc: Russell King <rmk@xxxxxxxxxxxxxxxx>
Cc: <stable@xxxxxxxxxx>
Signed-off-by: Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx>
---
include/linux/compiler-gcc.h | 10 +++++++++-
include/linux/compiler-gcc4.h | 4 ++++
2 files changed, 13 insertions(+), 1 deletion(-)
diff -puN include/linux/compiler-gcc.h~compiler-gcch-gcc-45-needs-noclone-and-noinline-on-__naked-functions include/linux/compiler-gcc.h
--- a/include/linux/compiler-gcc.h~compiler-gcch-gcc-45-needs-noclone-and-noinline-on-__naked-functions
+++ a/include/linux/compiler-gcc.h
@@ -58,8 +58,12 @@
* naked functions because then mcount is called without stack and frame pointer
* being set up and there is no chance to restore the lr register to the value
* before mcount was called.
+ *
+ * The asm() bodies of naked functions often depend on standard calling conventions,
+ * therefore they must be noinline and noclone. GCC 4.[56] currently fail to enforce
+ * this, so we must do so ourselves. See GCC PR44290.
*/
-#define __naked __attribute__((naked)) notrace
+#define __naked __attribute__((naked)) noinline __noclone notrace
#define __noreturn __attribute__((noreturn))
@@ -85,3 +89,7 @@
#define _gcc_header(x) __gcc_header(linux/compiler-gcc##x.h)
#define gcc_header(x) _gcc_header(x)
#include gcc_header(__GNUC__)
+
+#if !defined(__noclone)
+#define __noclone /* not needed */
+#endif
diff -puN include/linux/compiler-gcc4.h~compiler-gcch-gcc-45-needs-noclone-and-noinline-on-__naked-functions include/linux/compiler-gcc4.h
--- a/include/linux/compiler-gcc4.h~compiler-gcch-gcc-45-needs-noclone-and-noinline-on-__naked-functions
+++ a/include/linux/compiler-gcc4.h
@@ -48,6 +48,10 @@
* unreleased. Really, we need to have autoconf for the kernel.
*/
#define unreachable() __builtin_unreachable()
+
+/* Mark a function definition as prohibited from being cloned. */
+#define __noclone __attribute__((__noclone__))
+
#endif
#endif
_
Patches currently in -mm which might be from mikpe@xxxxxxxx are
compiler-gcch-gcc-45-needs-noclone-and-noinline-on-__naked-functions.patch
--
To unsubscribe from this list: send the line "unsubscribe mm-commits" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
