The patch titled acer-wmi/hp-wmi: use platform_device_unregister instead of platform_device_del in module_exit has been added to the -mm tree. Its filename is acer-wmi-hp-wmi-use-platform_device_unregister-instead-of-platform_device_del-in-module_exit.patch Before you just go and hit "reply", please: a) Consider who else should be cc'ed b) Prefer to cc a suitable mailing list as well c) Ideally: find the original patch on the mailing list and do a reply-to-all to that, adding suitable additional cc's *** Remember to use Documentation/SubmitChecklist when testing your code *** See http://userweb.kernel.org/~akpm/stuff/added-to-mm.txt to find out what to do about this The current -mm tree may be found at http://userweb.kernel.org/~akpm/mmotm/ ------------------------------------------------------ Subject: acer-wmi/hp-wmi: use platform_device_unregister instead of platform_device_del in module_exit From: Axel Lin <axel.lin@xxxxxxxxx> platform_device_unregister() will also call platform_device_put() to drop reference count. Signed-off-by: Axel Lin <axel.lin@xxxxxxxxx> Cc: Matthew Garrett <mjg@xxxxxxxxxx> Signed-off-by: Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx> --- drivers/platform/x86/acer-wmi.c | 2 +- drivers/platform/x86/hp-wmi.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff -puN drivers/platform/x86/acer-wmi.c~acer-wmi-hp-wmi-use-platform_device_unregister-instead-of-platform_device_del-in-module_exit drivers/platform/x86/acer-wmi.c --- a/drivers/platform/x86/acer-wmi.c~acer-wmi-hp-wmi-use-platform_device_unregister-instead-of-platform_device_del-in-module_exit +++ a/drivers/platform/x86/acer-wmi.c @@ -1358,7 +1358,7 @@ static void __exit acer_wmi_exit(void) { remove_sysfs(acer_platform_device); remove_debugfs(); - platform_device_del(acer_platform_device); + platform_device_unregister(acer_platform_device); platform_driver_unregister(&acer_platform_driver); printk(ACER_INFO "Acer Laptop WMI Extras unloaded\n"); diff -puN drivers/platform/x86/hp-wmi.c~acer-wmi-hp-wmi-use-platform_device_unregister-instead-of-platform_device_del-in-module_exit drivers/platform/x86/hp-wmi.c --- a/drivers/platform/x86/hp-wmi.c~acer-wmi-hp-wmi-use-platform_device_unregister-instead-of-platform_device_del-in-module_exit +++ a/drivers/platform/x86/hp-wmi.c @@ -611,7 +611,7 @@ static void __exit hp_wmi_exit(void) input_unregister_device(hp_wmi_input_dev); } if (hp_wmi_platform_dev) { - platform_device_del(hp_wmi_platform_dev); + platform_device_unregister(hp_wmi_platform_dev); platform_driver_unregister(&hp_wmi_driver); } } _ Patches currently in -mm which might be from axel.lin@xxxxxxxxx are wmi-fix-memory-leak-in-parse_wdg.patch acer-wmi-hp-wmi-use-platform_device_unregister-instead-of-platform_device_del-in-module_exit.patch intel_menlow-fix-memory-leaks-in-error-path.patch intel_menlow-fix-memory-leaks-in-error-path-fix.patch cdc-acm-fix-resource-reclaim-in-error-path-of-acm_probe.patch -- To unsubscribe from this list: send the line "unsubscribe mm-commits" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html