The patch titled fs/ocfs2/dlm: add missing spin_unlock has been added to the -mm tree. Its filename is fs-ocfs2-dlm-add-missing-spin_unlock.patch Before you just go and hit "reply", please: a) Consider who else should be cc'ed b) Prefer to cc a suitable mailing list as well c) Ideally: find the original patch on the mailing list and do a reply-to-all to that, adding suitable additional cc's *** Remember to use Documentation/SubmitChecklist when testing your code *** See http://userweb.kernel.org/~akpm/stuff/added-to-mm.txt to find out what to do about this The current -mm tree may be found at http://userweb.kernel.org/~akpm/mmotm/ ------------------------------------------------------ Subject: fs/ocfs2/dlm: add missing spin_unlock From: Julia Lawall <julia@xxxxxxx> Add a spin_unlock missing on the error path. Unlock as in the other code that leads to the leave label. The semantic match that finds this problem is as follows: (http://coccinelle.lip6.fr/) // <smpl> @@ expression E1; @@ * spin_lock(E1,...); <+... when != E1 if (...) { ... when != E1 * return ...; } ...+> * spin_unlock(E1,...); // </smpl> Signed-off-by: Julia Lawall <julia@xxxxxxx> Cc: Mark Fasheh <mfasheh@xxxxxxxx> Cc: Joel Becker <joel.becker@xxxxxxxxxx> Signed-off-by: Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx> --- fs/ocfs2/dlm/dlmdomain.c | 1 + 1 file changed, 1 insertion(+) diff -puN fs/ocfs2/dlm/dlmdomain.c~fs-ocfs2-dlm-add-missing-spin_unlock fs/ocfs2/dlm/dlmdomain.c --- a/fs/ocfs2/dlm/dlmdomain.c~fs-ocfs2-dlm-add-missing-spin_unlock +++ a/fs/ocfs2/dlm/dlmdomain.c @@ -1709,6 +1709,7 @@ retry: } if (dlm_protocol_compare(&dlm->fs_locking_proto, fs_proto)) { + spin_unlock(&dlm_domain_lock); mlog(ML_ERROR, "Requested locking protocol version is not " "compatible with already registered domain " _ Patches currently in -mm which might be from julia@xxxxxxx are origin.patch linux-next.patch fs-btrfs-use-memdup_user.patch fs-btrfs-use-err_cast.patch drivers-media-use-memdup_user.patch drivers-i2c-use-memdup_user.patch drivers-ide-use-memdup_user.patch fs-ubifs-use-err_cast.patch drivers-net-wireless-prism54-use-memdup_user.patch drivers-s390-net-use-memdup_user.patch drivers-scsi-libsas-use-sam_good.patch drivers-scsi-remove-unnecessary-null-test.patch drivers-message-move-dereference-after-null-test.patch drivers-scsi-correct-the-size-argument-to-kmalloc.patch drivers-scsi-use-memdup_user.patch drivers-block-use-memdup_user.patch drivers-staging-dream-camera-use-memdup_user.patch drivers-usb-gadget-use-memdup_user.patch mm-use-memdup_user.patch mm-use-err_cast.patch drivers-media-video-pvrusb2-add-missing-mutex_unlock.patch arch-x86-kernel-add-missing-spin_unlock.patch arch-ia64-kvm-add-missing-spin_unlock.patch drivers-video-omap2-displays-add-missing-mutex_unlock.patch drivers-message-i2o-exec-osmc-add-missing-mutex_unlock.patch drivers-char-n_gsmc-add-missing-spin_unlock_irqrestore.patch fs-ocfs2-dlm-add-missing-spin_unlock.patch drivers-staging-vme-bridges-add-missing-unlocks.patch -- To unsubscribe from this list: send the line "unsubscribe mm-commits" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html