The patch titled
gpiolib: make gpiochip_add() show a better error message
has been added to the -mm tree. Its filename is
gpiolib-make-gpiochip_add-show-a-better-error-message.patch
Before you just go and hit "reply", please:
a) Consider who else should be cc'ed
b) Prefer to cc a suitable mailing list as well
c) Ideally: find the original patch on the mailing list and do a
reply-to-all to that, adding suitable additional cc's
*** Remember to use Documentation/SubmitChecklist when testing your code ***
See http://userweb.kernel.org/~akpm/stuff/added-to-mm.txt to find
out what to do about this
The current -mm tree may be found at http://userweb.kernel.org/~akpm/mmotm/
------------------------------------------------------
Subject: gpiolib: make gpiochip_add() show a better error message
From: Ben Dooks <ben-linux@xxxxxxxxx>
The current message, 'not registered' is confusing as it implies it was
not registered with something, whereas printing 'failed to register'
implies it was the gpiochip_add() call that did not work correctly.
Signed-off-by: Ben Dooks <ben-linux@xxxxxxxxx>
Cc: David Brownell <david-b@xxxxxxxxxxx>
Signed-off-by: Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx>
---
drivers/gpio/gpiolib.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff -puN drivers/gpio/gpiolib.c~gpiolib-make-gpiochip_add-show-a-better-error-message drivers/gpio/gpiolib.c
--- a/drivers/gpio/gpiolib.c~gpiolib-make-gpiochip_add-show-a-better-error-message
+++ a/drivers/gpio/gpiolib.c
@@ -1118,7 +1118,7 @@ unlock:
return 0;
fail:
/* failures here can mean systems won't boot... */
- pr_err("gpiochip_add: gpios %d..%d (%s) not registered\n",
+ pr_err("gpiochip_add: gpios %d..%d (%s) failed to register\n",
chip->base, chip->base + chip->ngpio - 1,
chip->label ? : "generic");
return status;
_
Patches currently in -mm which might be from ben-linux@xxxxxxxxx are
origin.patch
linux-next.patch
sdhci-rename-sdhci-i-o-accessor-functions.patch
s3c6410-add-new-quirk-in-sdhci-driver-and-update-adma-descriptor-build.patch
s3c6410-enable-adma-feature-in-6410-sdhci-controller.patch
sdhci-enable-multiblock-transfers-in-sdhci-s3c.patch
s3c-rtc-driver-add-support-for-s3c64xx.patch
max732x-correct-nr_port-checking-off-by-one-error.patch
gpiolib-make-gpiochip_add-show-a-better-error-message.patch
--
To unsubscribe from this list: send the line "unsubscribe mm-commits" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
