The patch titled gpio: max732x: fix input configuration for open-drain pins has been added to the -mm tree. Its filename is gpio-max732x-fix-input-configuration-for-open-drain-pins.patch Before you just go and hit "reply", please: a) Consider who else should be cc'ed b) Prefer to cc a suitable mailing list as well c) Ideally: find the original patch on the mailing list and do a reply-to-all to that, adding suitable additional cc's *** Remember to use Documentation/SubmitChecklist when testing your code *** See http://userweb.kernel.org/~akpm/stuff/added-to-mm.txt to find out what to do about this The current -mm tree may be found at http://userweb.kernel.org/~akpm/mmotm/ ------------------------------------------------------ Subject: gpio: max732x: fix input configuration for open-drain pins From: Marc Zyngier <maz@xxxxxxxxxxxxxxx> Fix a bug I noticed while hacking on the max732x driver for interrupt support. According to the datasheets, open-drain pins have to be configured as output-high (which in that case is actually high impedance) to be used as input. Signed-off-by: Marc Zyngier <maz@xxxxxxxxxxxxxxx> Acked-by: Eric Miao <eric.y.miao@xxxxxxxxx> Signed-off-by: Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx> --- drivers/gpio/max732x.c | 7 +++++++ 1 file changed, 7 insertions(+) diff -puN drivers/gpio/max732x.c~gpio-max732x-fix-input-configuration-for-open-drain-pins drivers/gpio/max732x.c --- a/drivers/gpio/max732x.c~gpio-max732x-fix-input-configuration-for-open-drain-pins +++ a/drivers/gpio/max732x.c @@ -232,6 +232,13 @@ static int max732x_gpio_direction_input( return -EACCES; } + /* + * Open-drain pins must be set to high impedance (which is + * equivalent to output-high) to be turned into an input. + */ + if ((mask & chip->dir_output)) + max732x_gpio_set_value(gc, off, 1); + return 0; } _ Patches currently in -mm which might be from maz@xxxxxxxxxxxxxxx are linux-next.patch rtc-ds1302-add-some-abstraction-for-new-platform-support.patch gpio-add-interrupt-handling-capability-to-max732x.patch gpio-max732x-fix-input-configuration-for-open-drain-pins.patch -- To unsubscribe from this list: send the line "unsubscribe mm-commits" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html