The patch titled
ecryptfs: fix OOPs after umount
has been added to the -mm tree. Its filename is
ecryptfs-fix-oops-after-umount.patch
Before you just go and hit "reply", please:
a) Consider who else should be cc'ed
b) Prefer to cc a suitable mailing list as well
c) Ideally: find the original patch on the mailing list and do a
reply-to-all to that, adding suitable additional cc's
*** Remember to use Documentation/SubmitChecklist when testing your code ***
See http://userweb.kernel.org/~akpm/stuff/added-to-mm.txt to find
out what to do about this
The current -mm tree may be found at http://userweb.kernel.org/~akpm/mmotm/
------------------------------------------------------
Subject: ecryptfs: fix OOPs after umount
From: Christian Ehrhardt <lk@xxxxxxx>
Remove a d_drop in ecryptfs that is bogus IMHO. This d_drop unhashes a
perfectly valid and reachable dentry in the lower FS. The patch fixes
this perfectly reproducible kernel oops:
https://bugzilla.kernel.org/show_bug.cgi?id=10907
It and may or may not be related to this ecryptfs bug:
https://bugs.launchpad.net/ecryptfs/+bug/363734
At least the BUG_ON is on a dentry that should not be unhashed but is.
regards Christian
Signed-off-by: Christian Ehrhardt <lk@xxxxxxx>
Cc: "Rafael J. Wysocki" <rjw@xxxxxxx>
Cc: Eric Paris <eparis@xxxxxxxxxx>
Cc: Tyler Hicks <tyhicks@xxxxxxxxxxxxxxxxxx>
Cc: Dustin Kirkland <kirkland@xxxxxxxxxxxxx>
Signed-off-by: Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx>
---
fs/ecryptfs/super.c | 1 -
1 file changed, 1 deletion(-)
diff -puN fs/ecryptfs/super.c~ecryptfs-fix-oops-after-umount fs/ecryptfs/super.c
--- a/fs/ecryptfs/super.c~ecryptfs-fix-oops-after-umount
+++ a/fs/ecryptfs/super.c
@@ -85,7 +85,6 @@ static void ecryptfs_destroy_inode(struc
if (lower_dentry->d_inode) {
fput(inode_info->lower_file);
inode_info->lower_file = NULL;
- d_drop(lower_dentry);
}
}
ecryptfs_destroy_crypt_stat(&inode_info->crypt_stat);
_
Patches currently in -mm which might be from lk@xxxxxxx are
ecryptfs-fix-oops-after-umount.patch
--
To unsubscribe from this list: send the line "unsubscribe mm-commits" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
