The patch titled
coredump: plug a memory leak situation on dump_seek()
has been added to the -mm tree. Its filename is
coredump-plug-a-memory-leak-situation-on-dump_seek.patch
Before you just go and hit "reply", please:
a) Consider who else should be cc'ed
b) Prefer to cc a suitable mailing list as well
c) Ideally: find the original patch on the mailing list and do a
reply-to-all to that, adding suitable additional cc's
*** Remember to use Documentation/SubmitChecklist when testing your code ***
See http://userweb.kernel.org/~akpm/stuff/added-to-mm.txt to find
out what to do about this
The current -mm tree may be found at http://userweb.kernel.org/~akpm/mmotm/
------------------------------------------------------
Subject: coredump: plug a memory leak situation on dump_seek()
From: André Goddard Rosa <andre.goddard@xxxxxxxxx>
After having started writing the coredump, if filesystem reports an error
anytime while writing part of the core file, we would leak a memory page
when bailing out.
Signed-off-by: André Goddard Rosa <andre.goddard@xxxxxxxxx>
Acked-by: KOSAKI Motohiro <kosaki.motohiro@xxxxxxxxxxxxxx>
Cc: Alexander Viro <viro@xxxxxxxxxxxxxxxxxx>
Cc: Roland McGrath <roland@xxxxxxxxxx>
Cc: WANG Cong <amwang@xxxxxxxxxx>
Signed-off-by: Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx>
---
include/linux/coredump.h | 10 +++++++---
1 file changed, 7 insertions(+), 3 deletions(-)
diff -puN include/linux/coredump.h~coredump-plug-a-memory-leak-situation-on-dump_seek include/linux/coredump.h
--- a/include/linux/coredump.h~coredump-plug-a-memory-leak-situation-on-dump_seek
+++ a/include/linux/coredump.h
@@ -16,6 +16,8 @@ static inline int dump_write(struct file
static inline int dump_seek(struct file *file, loff_t off)
{
+ int ret = 1;
+
if (file->f_op->llseek && file->f_op->llseek != no_llseek) {
if (file->f_op->llseek(file, off, SEEK_CUR) < 0)
return 0;
@@ -29,13 +31,15 @@ static inline int dump_seek(struct file
if (n > PAGE_SIZE)
n = PAGE_SIZE;
- if (!dump_write(file, buf, n))
- return 0;
+ if (!dump_write(file, buf, n)) {
+ ret = 0;
+ break;
+ }
off -= n;
}
free_page((unsigned long)buf);
}
- return 1;
+ return ret;
}
#endif /* _LINUX_COREDUMP_H */
_
Patches currently in -mm which might be from andre.goddard@xxxxxxxxx are
linux-next.patch
coredump-plug-a-memory-leak-situation-on-dump_seek.patch
--
To unsubscribe from this list: send the line "unsubscribe mm-commits" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
