The patch titled ipmi: add proper offset for HP PCI interfaces has been added to the -mm tree. Its filename is ipmi-add-proper-offset-for-hp-pci-interfaces.patch Before you just go and hit "reply", please: a) Consider who else should be cc'ed b) Prefer to cc a suitable mailing list as well c) Ideally: find the original patch on the mailing list and do a reply-to-all to that, adding suitable additional cc's *** Remember to use Documentation/SubmitChecklist when testing your code *** See http://userweb.kernel.org/~akpm/stuff/added-to-mm.txt to find out what to do about this The current -mm tree may be found at http://userweb.kernel.org/~akpm/mmotm/ ------------------------------------------------------ Subject: ipmi: add proper offset for HP PCI interfaces From: Corey Minyard <cminyard@xxxxxxxxxx> On a PCI update, the offset for HP PCI interfaces to the IPMI controller was left off. Add the offset back in. The "dead code" dealing with first_reg_offset was removed in 2.6.32, so that is re-added. Signed-off-by: Corey Minyard <cminyard@xxxxxxxxxx> Signed-off-by: Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx> --- drivers/char/ipmi/ipmi_si_intf.c | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff -puN drivers/char/ipmi/ipmi_si_intf.c~ipmi-add-proper-offset-for-hp-pci-interfaces drivers/char/ipmi/ipmi_si_intf.c --- a/drivers/char/ipmi/ipmi_si_intf.c~ipmi-add-proper-offset-for-hp-pci-interfaces +++ a/drivers/char/ipmi/ipmi_si_intf.c @@ -2363,6 +2363,7 @@ static int __devinit ipmi_pci_probe(stru int rv; int class_type = pdev->class & PCI_ERMC_CLASSCODE_TYPE_MASK; struct smi_info *info; + int first_reg_offset = 0; info = kzalloc(sizeof(*info), GFP_KERNEL); if (!info) @@ -2401,6 +2402,9 @@ static int __devinit ipmi_pci_probe(stru info->addr_source_cleanup = ipmi_pci_cleanup; info->addr_source_data = pdev; + if (pdev->subsystem_vendor == PCI_HP_VENDOR_ID) + first_reg_offset = 1; + if (pci_resource_flags(pdev, 0) & IORESOURCE_IO) { info->io_setup = port_setup; info->io.addr_type = IPMI_IO_ADDR_SPACE; @@ -2408,7 +2412,7 @@ static int __devinit ipmi_pci_probe(stru info->io_setup = mem_setup; info->io.addr_type = IPMI_MEM_ADDR_SPACE; } - info->io.addr_data = pci_resource_start(pdev, 0); + info->io.addr_data = pci_resource_start(pdev, 0) + first_reg_offset; info->io.regspacing = DEFAULT_REGSPACING; info->io.regsize = DEFAULT_REGSPACING; _ Patches currently in -mm which might be from cminyard@xxxxxxxxxx are origin.patch ipmi-add-parameter-to-limit-cpu-usage-in-kipmid.patch ipmi-add-proper-offset-for-hp-pci-interfaces.patch -- To unsubscribe from this list: send the line "unsubscribe mm-commits" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html