The patch titled x86: move hp-wmi's probe function to .devinit.text has been added to the -mm tree. Its filename is x86-move-hp-wmis-probe-function-to-devinittext.patch Before you just go and hit "reply", please: a) Consider who else should be cc'ed b) Prefer to cc a suitable mailing list as well c) Ideally: find the original patch on the mailing list and do a reply-to-all to that, adding suitable additional cc's *** Remember to use Documentation/SubmitChecklist when testing your code *** See http://userweb.kernel.org/~akpm/stuff/added-to-mm.txt to find out what to do about this The current -mm tree may be found at http://userweb.kernel.org/~akpm/mmotm/ ------------------------------------------------------ Subject: x86: move hp-wmi's probe function to .devinit.text From: Uwe Kleine-König <u.kleine-koenig@xxxxxxxxxxxxxx> A pointer to hp_wmi_bios_setup is passed to the core via platform_driver_register and so the function must not disappear when the .init sections are discarded. Otherwise (if also having HOTPLUG=y) unbinding and binding a device to the driver via sysfs will result in an oops as does a device being registered late. An alternative to this patch is using platform_driver_probe instead of platform_driver_register plus removing the pointer to the probe function from the struct platform_driver. Signed-off-by: Uwe Kleine-König <u.kleine-koenig@xxxxxxxxxxxxxx> Cc: Frans Pop <elendil@xxxxxxxxx> Cc: Larry Finger <Larry.Finger@xxxxxxxxxxxx> Cc: Len Brown <lenb@xxxxxxxxxx> Cc: Helge Deller <deller@xxxxxx> Cc: Matthew Garrett <mjg@xxxxxxxxxx> Cc: Greg KH <greg@xxxxxxxxx> Acked-by: Matthew Garrett <mjg@xxxxxxxxxx> Signed-off-by: Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx> --- drivers/platform/x86/hp-wmi.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff -puN drivers/platform/x86/hp-wmi.c~x86-move-hp-wmis-probe-function-to-devinittext drivers/platform/x86/hp-wmi.c --- a/drivers/platform/x86/hp-wmi.c~x86-move-hp-wmis-probe-function-to-devinittext +++ a/drivers/platform/x86/hp-wmi.c @@ -57,7 +57,7 @@ enum hp_wmi_radio { HPWMI_WWAN = 2, }; -static int __init hp_wmi_bios_setup(struct platform_device *device); +static int __devinit hp_wmi_bios_setup(struct platform_device *device); static int __exit hp_wmi_bios_remove(struct platform_device *device); static int hp_wmi_resume_handler(struct device *device); @@ -446,7 +446,7 @@ static void cleanup_sysfs(struct platfor device_remove_file(&device->dev, &dev_attr_tablet); } -static int __init hp_wmi_bios_setup(struct platform_device *device) +static int __devinit hp_wmi_bios_setup(struct platform_device *device) { int err; int wireless = hp_wmi_perform_query(HPWMI_WIRELESS_QUERY, 0, 0); _ Patches currently in -mm which might be from u.kleine-koenig@xxxxxxxxxxxxxx are origin.patch linux-next.patch mtd-nand-fix-build-failure-caused-by-typo.patch mx1-mx2-einval-overwritten-in-second-iteration-in-mxc_gpio_setup_multiple_pins.patch hrtimer-correct-a-few-numbers-in-comments.patch clockevents-ensure-taht-min_delta_ns-is-increased-in-error-path.patch genirq-warn-about-irqf_sharedirqf_disabled-at-the-right-place.patch rtc-pcf2123-move-pcf2123_remove-to-devexittext.patch platform-drivers-move-probe-to-devinittext-in-arch-arm.patch platform-drivers-move-probe-to-devinittext-in-drivers-scsi.patch platform-drivers-move-probe-to-devinittext-in-drivers-video.patch x86-move-hp-wmis-probe-function-to-devinittext.patch i2c-move-i2c_omaps-probe-function-to-devinittext.patch w1-move-omap_hdqs-probe-function-to-devinittext.patch media-move-omap24xxcams-probe-function-to-devinittext.patch auxdisplay-move-cfag12864bfbs-probe-function-to-devinittext.patch net-move-am79c961s-probe-function-to-devinittext.patch -- To unsubscribe from this list: send the line "unsubscribe mm-commits" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html