The patch titled edac: mpc85xx fix build regression by removing unused debug code has been added to the -mm tree. Its filename is edac-mpc85xx-fix-build-regression-by-removing-unused-debug-code.patch Before you just go and hit "reply", please: a) Consider who else should be cc'ed b) Prefer to cc a suitable mailing list as well c) Ideally: find the original patch on the mailing list and do a reply-to-all to that, adding suitable additional cc's *** Remember to use Documentation/SubmitChecklist when testing your code *** See http://userweb.kernel.org/~akpm/stuff/added-to-mm.txt to find out what to do about this The current -mm tree may be found at http://userweb.kernel.org/~akpm/mmotm/ ------------------------------------------------------ Subject: edac: mpc85xx fix build regression by removing unused debug code From: Peter Tyser <ptyser@xxxxxxxxxxx> Some unused, unsupported debug code existed in the mpc85xx EDAC driver that resulted in a build failure when CONFIG_EDAC_DEBUG was defined: drivers/edac/mpc85xx_edac.c: In function 'mpc85xx_mc_err_probe': drivers/edac/mpc85xx_edac.c:1031: error: implicit declaration of function 'edac_mc_register_mcidev_debug' drivers/edac/mpc85xx_edac.c:1031: error: 'debug_attr' undeclared (first use in this function) drivers/edac/mpc85xx_edac.c:1031: error: (Each undeclared identifier is reported only once drivers/edac/mpc85xx_edac.c:1031: error: for each function it appears in.) Signed-off-by: Peter Tyser <ptyser@xxxxxxxxxxx> Signed-off-by: Doug Thompson <dougthompson@xxxxxxxxxxxx Signed-off-by: Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx> --- drivers/edac/mpc85xx_edac.c | 4 ---- 1 file changed, 4 deletions(-) diff -puN drivers/edac/mpc85xx_edac.c~edac-mpc85xx-fix-build-regression-by-removing-unused-debug-code drivers/edac/mpc85xx_edac.c --- a/drivers/edac/mpc85xx_edac.c~edac-mpc85xx-fix-build-regression-by-removing-unused-debug-code +++ a/drivers/edac/mpc85xx_edac.c @@ -892,10 +892,6 @@ static int __devinit mpc85xx_mc_err_prob mpc85xx_init_csrows(mci); -#ifdef CONFIG_EDAC_DEBUG - edac_mc_register_mcidev_debug((struct attribute **)debug_attr); -#endif - /* store the original error disable bits */ orig_ddr_err_disable = in_be32(pdata->mc_vbase + MPC85XX_MC_ERR_DISABLE); _ Patches currently in -mm which might be from ptyser@xxxxxxxxxxx are edac-mpc85xx-fix-bad-page-calculation.patch edac-mpc85xx-fix-build-regression-by-removing-unused-debug-code.patch linux-next.patch edac-mpc85xx-mask-ecc-syndrome-correctly.patch edac-mpc85xx-improve-sdram-error-reporting.patch edac-mpc85xx-use-resource_size-instead-of-raw-math.patch edac-e752x-fsb-ecc.patch edac-e752x-add-dram-scrubbing-support.patch -- To unsubscribe from this list: send the line "unsubscribe mm-commits" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html