The patch titled arm: mx1/mx2: -EINVAL overwritten in second iteration in mxc_gpio_setup_multiple_pins() has been added to the -mm tree. Its filename is mx1-mx2-einval-overwritten-in-second-iteration-in-mxc_gpio_setup_multiple_pins.patch Before you just go and hit "reply", please: a) Consider who else should be cc'ed b) Prefer to cc a suitable mailing list as well c) Ideally: find the original patch on the mailing list and do a reply-to-all to that, adding suitable additional cc's *** Remember to use Documentation/SubmitChecklist when testing your code *** See http://userweb.kernel.org/~akpm/stuff/added-to-mm.txt to find out what to do about this The current -mm tree may be found at http://userweb.kernel.org/~akpm/mmotm/ ------------------------------------------------------ Subject: arm: mx1/mx2: -EINVAL overwritten in second iteration in mxc_gpio_setup_multiple_pins() From: Roel Kluin <roel.kluin@xxxxxxxxx> Due to the `ret = gpio_request()' below in the loop, the initial -EINVAL value of ret is overwritten. Signed-off-by: Roel Kluin <roel.kluin@xxxxxxxxx> Cc: Russell King <rmk@xxxxxxxxxxxxxxxx> Acked-by: Uwe Kleine-König <u.kleine-koenig@xxxxxxxxxxxxxx> Signed-off-by: Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx> --- arch/arm/plat-mxc/iomux-mx1-mx2.c | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff -puN arch/arm/plat-mxc/iomux-mx1-mx2.c~mx1-mx2-einval-overwritten-in-second-iteration-in-mxc_gpio_setup_multiple_pins arch/arm/plat-mxc/iomux-mx1-mx2.c --- a/arch/arm/plat-mxc/iomux-mx1-mx2.c~mx1-mx2-einval-overwritten-in-second-iteration-in-mxc_gpio_setup_multiple_pins +++ a/arch/arm/plat-mxc/iomux-mx1-mx2.c @@ -116,14 +116,16 @@ int mxc_gpio_setup_multiple_pins(const i int i; unsigned gpio; unsigned mode; - int ret = -EINVAL; + int ret; for (i = 0; i < count; i++) { gpio = *p & (GPIO_PIN_MASK | GPIO_PORT_MASK); mode = *p & ~(GPIO_PIN_MASK | GPIO_PORT_MASK); - if (gpio >= (GPIO_PORT_MAX + 1) * 32) + if (gpio >= (GPIO_PORT_MAX + 1) * 32) { + ret = -EINVAL; goto setup_error; + } ret = gpio_request(gpio, label); if (ret) _ Patches currently in -mm which might be from roel.kluin@xxxxxxxxx are linux-next.patch acpi-fix-confusion-in-acpi_evaluate_string-in-comment.patch asus-acpi-remove-duplicate-comparison-of-asus_model-strings.patch thinkpad-acpi-wrong-thermal-attribute_group-removed-in-thermal_exit.patch gemini-wrong-registers-used-to-set-reg_level-in-gpio_set_irq_type.patch mx1-mx2-einval-overwritten-in-second-iteration-in-mxc_gpio_setup_multiple_pins.patch dma-cases-ipu_pix_fmt_bgra32-bgr32-and-abgr32-are-the-same-in-ipu_ch_param_set_size.patch powerpc-sky-cpu-redundant-or-incorrect-tests-on-unsigned.patch drivers-gpu-drm-drm_crtc_helperc-fix-setting-of-fb_changed-in-drm_crtc_helper_set_config.patch drivers-media-dvb-dvb-usb-dvb-usb-initc-return-enomem-if-kzalloc-failed-in-dvb_usb_device_init.patch ia64-wrong-attribute-of-hub-chip-written-in-uv_setup.patch mtd-hot-spin-and-code-duplication-in-nand_bcm_umi_bch_read_oobecc.patch mtd-change-positive-error-return-into-negative-in-mtd_do_writeoob.patch hisax-timeout-off-by-one-in-waitrecmsg.patch misdn-positive-error-return-should-be-negative-in-mode_hfcmulti.patch drivers-scsi-fnic-fnic_scsic-clean-up.patch drivers-scsi-gdthc-fix-buffer-overflow.patch drivers-scsi-lpfc-lpfc_vportc-fix-read-buffer-overflow.patch osst-fix-read-buffer-overflow.patch gdth-unmap-ccb_phys-when-scsi_add_host-fails-in-gdth_eisa_probe_one.patch ncr5380-bit-mr_dma_mode-set-twice-in-ncr5380_transfer_dma.patch scsi-pmcraid-redundant-check-in-pmcraid_check_ioctl_buffer.patch dc395x-decrease-iteration-for-tag_number-of-max_command-in-start_scsi.patch mpt2sas-fix-confusion-in-_scsih_sas_device_status_change_event.patch lpfc-two-branches-the-same-in-lpfc_decode_firmware_rev.patch lpfc-positive-error-return-into-negative.patch qla2xxx-negative-error-return-in-qla2x00_change_queue_depth.patch paride-fix-off-by-one-test.patch musb-test-always-evaluates-to-false.patch frv-duplicate-output_buffer-of-e03.patch frv-duplicate-output_buffer-of-e03-checkpatch-fixes.patch alpha-ptr_err-overwrites-einval-in-syscall-osf_mount.patch cryptocop-fix-assertion-in-create_output_descriptors.patch cris-v32-typo-in-crisv32_arbiter_unwatch.patch asiliantfb-fix-test-of-unsigned-in-asiliant_calc_dclk2.patch w1-fix-test-in-ds2482_wait_1wire_idle.patch -- To unsubscribe from this list: send the line "unsubscribe mm-commits" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html